I had tweaked that section a bit.. although I though it was clear what the benefit. Since it was a bit obvious I thought describing the feature and the API simplification would been enough..
I am hoping it would be clearer now. On Tue, Oct 17, 2017 at 4:37 AM, Tom Bentley <t.j.bent...@gmail.com> wrote: > Hi Clebert, > > The motivation section is written as more of a summary and doesn't really > give any motivation for this change. Can you explain why it would be > beneficial for Kafka to have this change? For example, if you have use > cases where the current way of instantiating a producer, consumer or admin > client is sub-optimal you should mention them. > > Cheers, > > Tom > > On 17 October 2017 at 08:15, Satish Duggana <satish.dugg...@gmail.com> > wrote: > >> You may need to update KIP with the details discussed in this thread in >> proposed changes section. >> >> >>My proposed format for the connection string would be: >> >>IP1:host1,IP2:host2,...IPN:hostn;parameterName=value1; >> parameterName2=value2;... >> parameterNameN=valueN >> Format should be >> host1:port1,host2:port2,…host:portn;param-name1=param-val1,.. >> >> >>Invalid conversions would throw InvalidArgumentException (with a >> description of the invalid conversion) >> >>Invalid parameters would throw InvalidArgumentException (with the name of >> the invalid parameter). >> >> Should throw IllegalArgumentException with respective message. >> >> Thanks, >> Satish. >> >> On Tue, Oct 17, 2017 at 4:46 AM, Clebert Suconic < >> clebert.suco...@gmail.com> >> wrote: >> >> > That works. >> > >> > On Mon, Oct 16, 2017 at 6:59 PM Ted Yu <yuzhih...@gmail.com> wrote: >> > >> > > Can't you use IllegalArgumentException ? >> > > >> > > Some example in current code base: >> > > >> > > clients/src/main/java/org/apache/kafka/clients/Metadata.java: >> > > throw new IllegalArgumentException("Max time to wait for metadata >> > updates >> > > should not be < 0 milliseconds"); >> > > >> > > On Mon, Oct 16, 2017 at 3:06 PM, Clebert Suconic < >> > > clebert.suco...@gmail.com> >> > > wrote: >> > > >> > > > I updated the wiki with the list on the proposed arguments. >> > > > >> > > > I also changed it to include a new Exception class that would be >> named >> > > > InvalidParameterException (since I couldn't find an existing >> Exception >> > > > class that I could reuse into this). (I could review the name or the >> > > > exception of course.. just my current proposal) >> > > > >> > > > On Mon, Oct 16, 2017 at 5:55 PM, Jakub Scholz <ja...@scholz.cz> >> wrote: >> > > > > Hi Clebert, >> > > > > >> > > > > I think it would be good if this could cover not only KafkaConsumer >> > and >> > > > > KafkaProducer but also the AdminClient. So that all three can be >> > > > configured >> > > > > the same way. >> > > > > >> > > > > The bootstrap servers are a list - you can provide multiple >> bootstrap >> > > > > servers. Maybe you add an example of how that will be configured. I >> > > > assume >> > > > > it will be >> > > > > "host:port,host2:port2;parameterName=value1;parameterName2=value2" >> > but >> > > > it >> > > > > would be great to have it documented. >> > > > > >> > > > > Thanks & Regards >> > > > > Jakub >> > > > > >> > > > > On Mon, Oct 16, 2017 at 11:30 PM, Clebert Suconic < >> > > > clebert.suco...@gmail.com >> > > > >> wrote: >> > > > > >> > > > >> I would like to start a discussion about KIP-209 >> > > > >> (https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> > > > >> 209+-+Connection+String+Support) >> > > > >> >> > > > >> This is an extension of my previous thread: >> > > > >> http://mail-archives.apache.org/mod_mbox/kafka-dev/201710. >> > > > >> mbox/%3cCAKF+bsoFbN13D-u20tUsP6G+aHX4BUNk=S8M4KyJxAt_ >> > > > >> oyv...@mail.gmail.com%3e >> > > > >> >> > > > >> this could make the bootstrap of a consumer or producer similar to >> > > > >> what users are already used when connecting into other systems, >> > being >> > > > >> a simple addition to Producer and Consumer, without breaking any >> > > > >> previous client usage. >> > > > >> >> > > > >> >> > > > >> -- >> > > > >> Clebert Suconic >> > > > >> >> > > > >> > > > >> > > > >> > > > -- >> > > > Clebert Suconic >> > > > >> > > >> > -- >> > Clebert Suconic >> > >> -- Clebert Suconic