Hi Paolo, The KIP looks good, I have a couple of comments:
1. partitionsAndOffsets could perhaps be `recordsToDelete`. 2. It seems a bit inconsistent that the argument is `RecordsToDelete`, but the result is just a `Long`. Should the result be `DeleteRecords` or something like that? It could then have a field logStartOffset or lowWatermark instead of having to document it via a comment only. Ismael On Tue, Oct 3, 2017 at 6:51 AM, Paolo Patierno <ppatie...@live.com> wrote: > Hi all, > > I didn't see any further discussion around this KIP, so I'd like to start > the vote for it. > > Just for reference : https://cwiki.apache.org/confl > uence/display/KAFKA/KIP-204+%3A+adding+records+deletion+ > operation+to+the+new+Admin+Client+API > > > Thanks, > > Paolo Patierno > Senior Software Engineer (IoT) @ Red Hat > Microsoft MVP on Azure & IoT > Microsoft Azure Advisor > > Twitter : @ppatierno<http://twitter.com/ppatierno> > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno> > Blog : DevExperience<http://paolopatierno.wordpress.com/> >
