+1 On Mon, Dec 11, 2017 at 7:07 PM, Colin McCabe <cmcc...@apache.org> wrote:
> +1 (non-binding) > > P.S. Suggest to use whenComplete instead of making addWaiter public. > > (The differences is very slight : addWaiter returns void, but > whenComplete returns a future which gets completed with either an > exception if the BiConsumer failed, or the value, otherwise.) > > Colin > > > On Mon, Dec 11, 2017, at 13:14, Ewen Cheslack-Postava wrote: > > +1 (binding) > > > > -Ewen > > > > On Mon, Dec 11, 2017 at 12:40 PM, Gwen Shapira <g...@confluent.io> > wrote: > > > > > +1 (binding) - nice API improvement, thanks for driving it! > > > > > > On Mon, Dec 11, 2017 at 11:52 AM Xavier Léauté <xav...@confluent.io> > > > wrote: > > > > > > > Thanks Steven, I believe I addressed all the comments. If the it > looks > > > good > > > > to you let's move forward on the vote. > > > > > > > > On Sat, Dec 9, 2017 at 12:50 AM Steven Aerts <steven.ae...@gmail.com > > > > > > wrote: > > > > > > > > > Hello Xavier, > > > > > > > > > > for me it is perfect to take it along. > > > > > I made a few small remarks in your PR. > > > > > > > > > > Thanks > > > > > > > > > > Op za 9 dec. 2017 om 01:29 schreef Xavier Léauté < > xav...@confluent.io > > > >: > > > > > > > > > > > Hi Steve, I just posted in the discussion thread, there's just > one > > > tiny > > > > > fix > > > > > > I think would be useful to add while we're making changes to this > > > API. > > > > > > Do you mind having a look? > > > > > > > > > > > > On Fri, Dec 8, 2017 at 11:37 AM Mickael Maison < > > > > mickael.mai...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > +1 (non binding) > > > > > > > Thanks for the KIP > > > > > > > > > > > > > > On Fri, Dec 8, 2017 at 6:53 PM, Tom Bentley < > t.j.bent...@gmail.com > > > > > > > > > > wrote: > > > > > > > > +1 > > > > > > > > > > > > > > > > On 8 December 2017 at 18:34, Ted Yu <yuzhih...@gmail.com> > wrote: > > > > > > > > > > > > > > > >> +1 > > > > > > > >> > > > > > > > >> On Fri, Dec 8, 2017 at 3:49 AM, Steven Aerts < > > > > > steven.ae...@gmail.com> > > > > > > > >> wrote: > > > > > > > >> > > > > > > > >> > Hello everybody, > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > I think KIP-218 is crystallized enough to start voting. > > > > > > > >> > > > > > > > > >> > KIP documentation: > > > > > > > >> > > > > > > > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > > >> > 218%3A+Make+KafkaFuture.Function+java+8+lambda+compatible > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > Thanks, > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > Steven > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > -- -- Guozhang
