Matthias: Nicely written KIP. "in_place" : can this be "in-place" ? Underscore may sometimes be miss typed (as '-'). I think using '-' is more friendly to user.
public interface ReadOnlyKeyValueTimestampStore<K, V> { Is ReadOnlyKeyValueStoreWithTimestamp better name for the class ? Thanks On Thu, Mar 8, 2018 at 1:29 PM, Guozhang Wang <wangg...@gmail.com> wrote: > Hello Matthias, thanks for the KIP. > > I've read through the upgrade patch section and it looks good to me, if you > already have a WIP PR for it could you also share it here so that people > can take a look? > > I'm +1 on the KIP itself. But large KIPs like this there are always some > devil hidden in the details, so I think it is better to have the > implementation in parallel along with the design discussion :) > > > Guozhang > > > On Wed, Mar 7, 2018 at 2:12 PM, Matthias J. Sax <matth...@confluent.io> > wrote: > > > Hi, > > > > I want to propose KIP-258 for the Streams API to allow storing > > timestamps in RocksDB. This feature is the basis to resolve multiple > > tickets (issues and feature requests). > > > > Looking forward to your comments about this! > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 258%3A+Allow+to+Store+Record+Timestamps+in+RocksDB > > > > > > -Matthias > > > > > > > > > -- > -- Guozhang >