Thanks for voting everyone, KIP is accepted with 5 binding +1 and 5 non-binding +1s.
PR is already merged and there are upgrade notes about the potential memory impact. -Ewen On Wed, Mar 7, 2018 at 9:25 PM, Ted Yu <yuzhih...@gmail.com> wrote: > +1 > -------- Original message --------From: Guozhang Wang <wangg...@gmail.com> > Date: 3/7/18 9:17 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: > [VOTE] KIP-186: Increase offsets retention default to 7 days > +1 (binding). > > On Wed, Mar 7, 2018 at 5:04 PM, James Cheng <wushuja...@gmail.com> wrote: > > > +1 (non-binding) > > > > -James > > > > > On Mar 7, 2018, at 1:20 PM, Jay Kreps <j...@confluent.io> wrote: > > > > > > +1 > > > > > > I think we can improve this in the future, but this simple change will > > > avoid a lot of pain. Thanks for reviving it Ewen. > > > > > > -Jay > > > > > > On Mon, Mar 5, 2018 at 11:35 AM, Ewen Cheslack-Postava < > > e...@confluent.io> > > > wrote: > > > > > >> I'd like to kick off voting for KIP-186: > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >> 186%3A+Increase+offsets+retention+default+to+7+days > > >> > > >> This is the trivial fix that people in the DISCUSS thread were in > favor > > of. > > >> There are some ideas for further refinements, but I think we can > follow > > up > > >> with those in subsequent KIPs, see the discussion thread for details. > > Also > > >> note this is related, but complementary, to > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >> 211%3A+Revise+Expiration+Semantics+of+Consumer+Group+Offsets > > >> . > > >> > > >> And of course +1 (binding) from me. > > >> > > >> Thanks, > > >> Ewen > > >> > > > > > > > -- > -- Guozhang >