+1 (non binding) Thanks Viktor. Please remove "Unknown" AlterOperation type from Wire Format Types section as you did from the AdminClient APIs section.
On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi <viktorsomo...@gmail.com> wrote: > Hi Everyone, > > I've started a vote on KIP-248 > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-248+-+Create+New+ > ConfigCommand+That+Uses+The+New+AdminClient#KIP-248- > CreateNewConfigCommandThatUsesTheNewAdminClient-DescribeQuotas> > a few weeks ago but at the time I got a couple more comments and it was > very close to 1.1 feature freeze, people were occupied with that, so I > wanted to restart the vote on this. > > > *Summary of the KIP* > For those who don't have context I thought I'd summarize it in a few > sentence. > *Problem & Motivation: *The basic problem that the KIP tries to solve is > that kafka-configs.sh (which in turn uses the ConfigCommand class) uses a > direct zookeeper connection. This is not desirable as getting around the > broker opens up security issues and prevents the tool from being used in > deployments where only the brokers are exposed to clients. Also a somewhat > smaller motivation is to rewrite the tool in java as part of the tools > component so we can get rid of requiring the core module on the classpath > for the kafka-configs tool. > *Solution:* > - I've designed new 2 protocols: DescribeQuotas and AlterQuotas. > - Also redesigned the output format of the command line tool so it provides > a nicer result. > - kafka-configs.[sh/bat] will use a new java based ConfigCommand that is > placed in tools. > > > I'd be happy to receive any votes or feedback on this. > > Regards, > Viktor >
