Thanks Debasish for the KIP! Will make another pass on the PR itself, but the KIP itself looks good. I'm +1 (binding).
Guozhang On Mon, Apr 16, 2018 at 10:51 AM, John Roesler <j...@confluent.io> wrote: > Thanks again for this effort. I'm +1 (non-binding). > -John > > On Mon, Apr 16, 2018 at 9:39 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > Thanks for the contribution. I haven't reviewed all the new APIs in > detail, > > but the general approach sounds good to me. +1 (binding). > > > > Ismael > > > > On Wed, Apr 11, 2018 at 3:09 AM, Debasish Ghosh < > > debasish.gh...@lightbend.com> wrote: > > > > > Hello everyone - > > > > > > This is in continuation to the discussion regarding > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 270+-+A+Scala+Wrapper+Library+for+Kafka+Streams, > > > which is a KIP for implementing a Scala wrapper library for Kafka > > Streams. > > > > > > We have had a PR (https://github.com/apache/kafka/pull/4756) for quite > > > some > > > time now and we have had lots of discussions and suggested > improvements. > > > Thanks to all who participated in the discussion and came up with all > the > > > suggestions for improvements. > > > > > > The purpose of this thread is to get an agreement on the implementation > > and > > > have it included as part of Kafka. > > > > > > Looking forward .. > > > > > > regards. > > > > > > -- > > > Debasish Ghosh > > > Principal Engineer > > > > > > Twitter: @debasishg > > > Blog: http://debasishg.blogspot.com > > > Code: https://github.com/debasishg > > > > > > -- -- Guozhang
