Hi Ron, Thanks for the pointer! I'll take a look at KIP 269. I will also put together a PR to demonstrate what the implementation might look like.
Thanks, Robert On Wed, May 9, 2018 at 6:44 AM, Ron Dagostino <rndg...@gmail.com> wrote: > Hi Robert. You may find KIP-269: Substitution Within Configuration Values > ( > https://cwiki.apache.org/confluence/display/KAFKA/KIP+ > 269+Substitution+Within+Configuration+Values) to be interesting. I don't > know if it is relevant here -- I agree with Magesh, more concrete details > would help, including to determine if KIP 269 is potentially adaptable to > fit -- but I thought you should know about it in case you were not aware of > it and it does turn out to be useful. Note that I will soon be marking KIP > 269 "Inactive" with respect to the core Kafka implementation, but that > doesn't mean the ideas (or even the code) couldn't be used in the Connect > framework if it was determined that would be appropriate. I hope you find > it helpful. > > Ron > > > On Wed, May 9, 2018 at 1:10 AM, Magesh Nandakumar <mage...@confluent.io> > wrote: > > > Hi Robert, > > > > Thanks for the KIP. I think, this will be a great addition to the > > framework. I think, will be great if the KIP can elaborate a little bit > > more on how implementations would look like with an example. > > Also, would be good to provide a reference implementation as well. > > > > The other questions I had were > > > > 1. How would the framework get the delayMs for void > scheduleConfigReload( > > long delayMs); > > 2. Would the start methods in SourceTask and SinkTask get the configs > with > > all the indirect references resolved. If so, trying to understand > > the intent of the config() in SourceTaskContext and the SinkTaskContext > > 3. What if the provider itself needs some kind of secrets to be > configured > > to connect to it? I assume that's out of scope for this proposal but > wanted > > to clarify it. > > > > Thanks > > Magesh > > > > On Tue, May 8, 2018 at 1:52 PM, Robert Yokota <rayok...@gmail.com> > wrote: > > > > > Hi, > > > > > > I would like to start a discussion for KIP-297 to externalize secrets > > from > > > Kafka Connect configurations. Any feedback is appreciated. > > > < > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 297%3A+Externalizing+Secrets+for+Connect+Configurations > > > > > > > > > > JIRA: <https://issues.apache.org/jira/browse/KAFKA-6886> > > > > > > Thanks in advance, > > > Robert > > > > > >
