Thanks, Ismael. I added the "Testing Strategy" section to the KIP outlining the findings.
I am also closing this vote with 3 binding and 1 non-binding +1s and no objections. Thanks everyone for your review and feedback. - Dhruvil On Tue, May 15, 2018 at 11:04 AM, Ismael Juma <ism...@juma.me.uk> wrote: > Thanks for the KIP Dhruvil, this is a welcome improvement! My understanding > is that you have done some work to validate that the change has the desired > effect, it would be good to include that information in the "Testing > Strategy" section. > > +1 (binding) > > Ismael > > On Wed, May 2, 2018 at 9:27 AM Dhruvil Shah <dhru...@confluent.io> wrote: > > > Hi all, > > > > I would like to start the vote on KIP-238: Efficient Memory Usage for > > Down-Conversion. > > > > For reference, the link to the KIP is here: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 283%3A+Efficient+Memory+Usage+for+Down-Conversion > > > > and the discussion thread is here: > > https://www.mail-archive.com/dev@kafka.apache.org/msg86799.html > > > > Thanks, > > Dhruvil > > >
