Hi, the only real usecase for the REST interface I can see is providing health/liveness checks for mesos/kubernetes. It's also true that the API can be left as is and e.g. not exposed publicly on the platform level, but this would still leave opportunities to accidentally mess something up internally, so it's mostly a safety concern.
Regarding the option renaming: I agree that it's not necessary as it's not clashing with anything, my reasoning is that assuming some other offset storage appears in the future, having all config properties at the root level of offset.storage.* _MIGHT_ introduce clashes in the future, so this is just a suggestion for introducing a convention of offset.storage.<store>.<properties>, which the existing property offset.storage.file.filename already adheres to. But in general, yes -- this can be left as is. 2018-05-17 1:20 GMT+03:00 Jakub Scholz <ja...@scholz.cz>: > Hi, > > What do you plan to use the read-only REST interface for? Is there > something what you cannot get through metrics interface? Otherwise it might > be easier to just disable the REST interface (either in the code, or just > on the platform level - e.g. in Kubernetes). > > Also, I do not know what is the usual approach in Kafka ... but do we > really have to rename the offset.storage.* options? The current names do > not seem to have any collision with what you are adding and they would get > "out of sync" with the other options used in connect (status.storage.* and > config.storage.*). So it seems a bit unnecessary change to me. > > Jakub > > > > On Wed, May 16, 2018 at 10:10 PM Saulius Valatka <saulius...@gmail.com> > wrote: > > > Hi, > > > > I'd like to start a discussion on the following KIP: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 304%3A+Connect+runtime+mode+improvements+for+container+platforms > > > > Basically the idea is to make it easier to run separate instances of > Kafka > > Connect hosting isolated connectors on container platforms such as Mesos > or > > Kubernetes. > > > > In particular it would be interesting to hear opinions about the proposed > > read-only REST API mode, more specifically I'm concerned about the > > possibility to implement it in distributed mode as it appears the > framework > > is using it internally ( > > > > https://github.com/apache/kafka/blob/trunk/connect/ > runtime/src/main/java/org/apache/kafka/connect/runtime/ > distributed/DistributedHerder.java#L1019 > > ), > > however this particular API method appears to be undocumented(?). > > > > Looking forward for your feedback. > > >
