Thanks a lot Guozhang. I have updated the KIP to reflect that minor change.
On Mon, May 21, 2018 at 9:08 AM, Guozhang Wang <wangg...@gmail.com> wrote: > Thanks for the KIP, +1 from me (binding) > > One minor suggestion: in "class TaskState" constructor, the passed in > parameter of `worker` could be `workerId`, to be consistent with others in > ConnectorState? > > > Guozhang > > > On Fri, May 18, 2018 at 9:44 AM, Randall Hauch <rha...@gmail.com> wrote: > > > +1 (non-binding) > > > > Regards, > > Randall > > > > On Fri, May 18, 2018 at 11:32 AM, Konstantine Karantasis < > > konstant...@confluent.io> wrote: > > > > > +1 (non-binding) > > > > > > - Konstantine > > > > > > On Thu, May 17, 2018 at 10:05 PM, Ewen Cheslack-Postava < > > e...@confluent.io > > > > > > > wrote: > > > > > > > +1 (binding) > > > > > > > > Thanks, > > > > Ewen > > > > > > > > On Thu, May 17, 2018 at 12:16 PM Ted Yu <yuzhih...@gmail.com> wrote: > > > > > > > > > +1 > > > > > -------- Original message --------From: Gwen Shapira < > > > g...@confluent.io> > > > > > Date: 5/17/18 12:02 PM (GMT-08:00) To: dev <dev@kafka.apache.org > > > > > > > Subject: Re: [VOTE] KIP-285: Connect Rest Extension Plugin > > > > > LGTM. +1. > > > > > > > > > > On Wed, May 16, 2018 at 8:19 PM, Magesh Nandakumar < > > > mage...@confluent.io > > > > > > > > > > wrote: > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > After a good round of discussions with excellent feedback and no > > > major > > > > > > objections, I would like to start a vote on KIP-285: Connect Rest > > > > > Extension > > > > > > Plugin. > > > > > > > > > > > > KIP: < > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > 285%3A+Connect+Rest+Extension+Plugin > > > > > > > > > > > > > > > > > > > > > > > > > JIRA: <*https://issues.apache.org/jira/browse/KAFKA-6776 > > > > > > <https://issues.apache.org/jira/browse/KAFKA-6776>*> > > > > > > > > > > > > Discussion thread: < > > > > > > https://www.mail-archive.com/dev@kafka.apache.org/msg86910.html> > > > > > > > > > > > > Thanks, > > > > > > Magesh > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > *Gwen Shapira* > > > > > Product Manager | Confluent > > > > > 650.450.2760 | @gwenshap > > > > > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog > > > > > <http://www.confluent.io/blog> > > > > > > > > > > > > > > > > > > -- > -- Guozhang >
