Hello everyone, While implementing the PR for this KIP I realized there is once place which we should consider modifying on public APIs as well: StreamPartitioner#partition, to add the topic name string. Note it will be a incompatible change that requires users who have customized StreamPartitioner implementations.
I've updated the wiki page of KIP-303, please recast your vote on this thread. Thanks!!! Guozhang On Thu, May 17, 2018 at 3:15 PM, John Roesler <j...@confluent.io> wrote: > +1 non-binding > > On Thu, May 17, 2018 at 4:44 PM, Matthias J. Sax <matth...@confluent.io> > wrote: > > > +1 (binding) > > > > > > On 5/17/18 12:18 PM, Ted Yu wrote: > > > +1 > > > -------- Original message --------From: Gwen Shapira < > g...@confluent.io> > > Date: 5/17/18 11:53 AM (GMT-08:00) To: dev <dev@kafka.apache.org> > > Subject: Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka > Streams' > > Topology Sink > > > Yay, its about time :) > > > > > > +1 > > > > > > On Thu, May 17, 2018 at 12:38 PM, Guozhang Wang <wangg...@gmail.com> > > wrote: > > > > > >> Hello folks, > > >> > > >> I'd like to start a voting thread on adding dynamic routing > > functionality > > >> in Streams sink node. Please find a KIP here: > > >> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > >> 303%3A+Add+Dynamic+Routing+in+Streams+Sink > > >> > > >> > > >> And the PR itself ready for review as well under KAFKA-4936: > > >> > > >> https://github.com/apache/kafka/pull/5018 > > >> > > >> > > >> > > >> Thanks! > > >> -- Guozhang > > >> > > > > > > > > > > > > > > -- -- Guozhang
