+1 (binding) Just follow up on the existing version of the KIP, so nothing new here. Possibly a bit disruptive given how quick the 1.0 -> 2.0 jump happened, but it's the right time to remove it.
-Ewen On Thu, May 24, 2018 at 8:13 AM Viktor Somogyi <viktorsomo...@gmail.com> wrote: > +1 (non-binding) > > I like this KIP. The new-consumer option is actually sometimes confusing, > commands could work without it and 2.0.0 seems like a good time to do it. > We should make sure to add enough tests to provide coverage. > > On Wed, May 23, 2018 at 7:32 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > lgtm > > > > On Wed, May 23, 2018 at 9:04 AM, Paolo Patierno <ppatie...@live.com> > > wrote: > > > > > Sorry ... I hope it's not too late but I created the KIP-176 on > September > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 176%3A+Remove+deprecated+new-consumer+option+for+tools > > > > > > but due to be a breaking change, I needed to wait for a major release > ... > > > and the right time is now. > > > Can you vote for that adding to the release plan, please ? > > > > > > Thanks, > > > > > > Paolo Patierno > > > Principal Software Engineer (IoT) @ Red Hat > > > Microsoft MVP on Azure & IoT > > > Microsoft Azure Advisor > > > > > > Twitter : @ppatierno<http://twitter.com/ppatierno> > > > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno> > > > Blog : DevExperience<http://paolopatierno.wordpress.com/> > > > > > >
