Part of the motivation for this KIP is to make these interfaces functional interfaces. But I think that may not be desirable due to the method that passes headers. So, it doesn't make sense to discuss two separate changes to the same interfaces in isolation, we should figure out how we want them to work holistically.
Ismael On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <chia7...@apache.org> wrote: > > The KIP needs 3 binding votes to pass. > > Thanks for the reminder. I will reopen the ballot box until we get 3 > tickets. > > > I still think we should include the details of how things will look like > > with the headers being passed to serializers/deserializers to ensure > > things actually make sense as a whole. > > This KIP is unrelated to the both methods - serialize() and deserialize(). > We won't add the default implementation to them in this kip. Please correct > me if I didn't catch what you said. > > Cheers, > Chia-Ping > > On 2018/07/09 01:55:41, Ismael Juma <isma...@gmail.com> wrote: > > The KIP needs 3 binding votes to pass. I still think we should include > the > > details of how things will look like with the headers being passed to > > serializers/deserializers to ensure things actually make sense as a > whole. > > > > Ismael > > > > > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <chia7...@apache.org> wrote: > > > > > All, > > > > > > The 72 hours has passed. The vote result of KIP-313 is shown below. > > > > > > 1 binding vote (Matthias J. Sax) > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping) > > > > > > Cheers, > > > Chia-Ping > > > > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <chia7...@apache.org> wrote: > > > > hi all, > > > > > > > > I would like to start voting on "KIP-331 Add default implementation > to > > > close() and configure() for Serializer, Deserializer and Serde" > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde > > > > > > > > Cheers, > > > > Chia-Ping > > > > > > > > > >
