+1 -------- Original message --------From: Kamal Chandraprakash <kamal.chandraprak...@gmail.com> Date: 8/22/18 3:19 AM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-336: Consolidate ExtendedSerializer/Serializer and ExtendedDeserializer/Deserializer +1
Thanks for the KIP! On Wed, Aug 22, 2018 at 2:48 PM Viktor Somogyi-Vass <viktorsomo...@gmail.com> wrote: > Hi All, > > I'd like to start a vote on this KIP ( > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242) > which aims to refactor ExtendedSerializer/Serializer and > ExtendedDeserializer/Deserializer. > > To summarize what's the motivation: > > When headers were introduced by KIP-82 the ExtendedSerializer and > ExtendedDeserializer classes were created in order to keep interface > compatibility but still add `T deserialize(String topic, Headers headers, > byte[] data);` and `byte[] serialize(String topic, Headers headers, T > data);` methods that consume the headers for serialization/deserialization. > The reason for doing so was that Kafka at that time needed be compatbile > with Java 7. Since we're not compiling on Java 7 anymore (KAFKA-4423) we'll > try consolidate the way we're using these in a backward compatible fashion: > deprecating the Extended* classes and moving the aforementioned methods up > in the class hierarchy. > > I'd be happy to get votes or additional feedback on this. > > Viktor >
