+1

In the Motivation section, you can quote the comment from pull request so
that reader doesn't have to click through.

Cheers

On Thu, Aug 23, 2018 at 12:13 PM Joan Goyeau <j...@goyeau.com> wrote:

> Hi,
>
> As pointed out in this comment #5539 (comment)
> <https://github.com/apache/kafka/pull/5539#discussion_r212380648> the
> object FunctionConversions is only of internal use and therefore should be
> private to the lib only so that we can do changes without going through KIP
> like this one.
>
> KIP:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-363%3A+Make+FunctionConversions+private
>
> Thanks
>

Reply via email to