Thanks for your feedback, Kevin & Viktor! I will update the KIP next week.
@Kevin - I also had to write sed based one-liners when I ran performance tests to extract results (that were displayed in some charts later). 1. Initially, I wanted to overwrite any exisisting file and document this behaviour in the help message. Throwing an exception might be a better idea. 2. Yes, tools shall continue to print out all the information to standard output/error. Specifying the output-path option will only cause that the final results (last line about the performance metrics) will be printed to the given file. @ Viktor 1. Thanks, I will add an example. 2. I would suggest the use of Apache Commons CSV library (https://commons.apache.org/proper/commons-csv/) to avoid reinventing the wheel. It is an implementation detail, so I would not add this to the KIP. 3. Delimiters/separators shall not be configurable (to keep things simple, only CSV is supported). Fields within a record are separated by commas; records are separated by line break(s). More info about the CSV format: https://tools.ietf.org/html/rfc4180#section-1 Best, - Attila Viktor Somogyi-Vass <viktorsomo...@gmail.com> (időpont: 2018. aug. 24., P, 14:27) ezt írta: > Hi Attila, > > Thanks for the KIP, I think overall it looks good. I have three comments: > 1. Would you mind adding an example? (Later on we'd need anyway for the > public doc.) > 2. Do you want to add any 3rd party CSV reader/writer library or will you > implement that too? > 3. What is the separator or is that configurable? > > Cheers, > Viktor > > On Fri, Aug 24, 2018 at 8:18 AM Kevin Lu <lu.ke...@berkeley.edu> wrote: > > > Hi Attila, > > > > Thanks for the KIP. > > > > I think this would be a useful feature. Every time I have to benchmark > > using these performance tools, I end up redirecting the output to a file > > anyways. > > > > Just a couple minor questions... > > > > 1. If the configured file already exists, what would be the outcome? My > > intuition is that the performance tool will spit out some type of error > and > > quit as we do not want to accidentally overwrite files. > > > > 2. Will the performance tool still output directly to shell if this > option > > is specified? > > > > Regards, > > Kevin > > > > On Wed, Aug 22, 2018 at 12:16 PM Attila Sasvári <asasv...@apache.org> > > wrote: > > > > > Hi all, > > > > > > I have created a minor KIP to allow consumer and producer performance > > tools > > > to print final results to output file in CSV format. > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-363%3A+Allow+performance+tools+to+print+final+results+to+output+file > > > > > > Please take a look and share your thoughts! > > > > > > Thanks, > > > Attila > > > > > >
