Sounds good. Thanks for cleaning up the warnings! Colin
On Mon, Nov 12, 2018, at 22:29, Ismael Juma wrote: > Hi all, > > As part of KAFKA-7612, all javac warnings were fixed or suppressed. To> > prevent them from reappearing, javac warnings are now treated as > errors. We> still have some scalac warnings (see KAFKA-7614 for details on > what's> needed to eliminate them) and 3 xlint warnings are not yet enabled > (KAFKA-7613). > > Before merging PRs that were submitted before KAFKA-7612 was > merged, it's a> good idea to rerun the PR tests. > > Ismael