>>This would allow for fast failure on
compilation and checkstyle problems, but let the whole test suite run in
spite of test failures.

+1 for that as it will be very useful.

Thanks,
Satish.

On Fri, Dec 21, 2018 at 8:10 PM David Arthur <mum...@gmail.com> wrote:
>
> Since this is a relatively simple change, I went ahead and opened up a PR
> here https://github.com/apache/kafka/pull/6059
>
> On Fri, Dec 21, 2018 at 2:15 AM Manikumar <manikumar.re...@gmail.com> wrote:
>
> > +1 fo the suggestion.
> >
> > On Fri, Dec 21, 2018 at 2:38 AM David Arthur <mum...@gmail.com> wrote:
> >
> > > In the jenkins.sh file, we have the following comment:
> > >
> > > "In order to provide faster feedback, the tasks are ordered so that
> > faster
> > > tasks are executed in every module before slower tasks (if possible)"
> > >
> > >
> > > but then we proceed to use the Gradle --continue flag. This means PRs
> > won't
> > > get notified of problems until the whole build finishes.
> > >
> > >
> > > What do folks think about splitting the build invocation into a
> > validation
> > > step and a test step? The validation step would omit the continue flag,
> > but
> > > the test step would include it. This would allow for fast failure on
> > > compilation and checkstyle problems, but let the whole test suite run in
> > > spite of test failures.
> > >
> > >
> > > Cheers,
> > > David
> > >
> >
>
>
> --
> David Arthur

Reply via email to