Hi Colin,
If the configProvider is not configured we will return the unresolved value as
is, so from the example the value returned will be
${file:/path/to/variables.properties:foo.bar} instead of the resolved value.
We currently wont be supporting mechanism to update via subscribe so it will be
snapshot of what the configuration key was when the constructor was invoked.
Thanks,
Tejal
On 2019/01/23 22:09:02, "Colin McCabe" <cmcc...@apache.org> wrote:
> Hi Tejal,
>
> Looks good overall.
>
> Can you please add this KIP to the wiki page at
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
> ?
>
> What is the behavior when there is a configuration key which specifies a
> ConfigurationProvider which has not been supplied? For example, if I have a
> map with a key "foo.bar" which has a value
> "${file:/path/to/variables.properties:foo.bar}", but no file provider is
> configured, what will happen?
>
> KIP-297 includes a mechanism for callers to "subscribe" to changes to a
> configuration key. If such a change happens here, are we going to change the
> value of the key in the AbstractConfig? Or will it continue to be a snapshot
> of what the configuration key was when the constructor was invoked?
>
> best,
> Colin
>
> On Wed, Jan 23, 2019, at 04:21, Dongjin Lee wrote:
> > +1 (non-binding)
> >
> > Best,
> > Dongjin
> >
> > On Wed, Jan 23, 2019 at 2:54 AM Ryanne Dolan <ryannedo...@gmail.com> wrote:
> >
> > > +1 non-binding, thanks!
> > >
> > > Ryanne
> > >
> > > On Tue, Jan 22, 2019 at 11:38 AM te...@confluent.io <te...@confluent.io>
> > > wrote:
> > > >
> > > > Hi all,
> > > >
> > > > We would like to start vote on KIP-421 to to enhance the AbstractConfig
> > > base class to support replacing variables in configurations just prior to
> > > parsing and validation.
> > > >
> > > > Link for the KIP:
> > > >
> > > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-421%3A+Support+resolving+externalized+secrets+in+AbstractConfig
> > > >
> > > >
> > > > Thanks,
> > > > Tejal
> > >
> > --
> > *Dongjin Lee*
> >
> > *A hitchhiker in the mathematical world.*
> > *github: <http://goog_969573159/>github.com/dongjinleekr
> > <https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck:
> > speakerdeck.com/dongjin
> > <https://speakerdeck.com/dongjin>*
> >
>
