Hi Everyone, This KIP passes with three binding +1 votes from Matthias, Bill, and Guozhang and two non-binding +1 from votes from John and Bruno. I would like to thank everyone for the feedback and votes, with special thanks to John for guiding me through my first KIP!
A very early stage PR is available at https://github.com/apache/kafka/pull/6593. Cheers, Maarten On Mon, 22 Apr 2019 07:55 AM John Roesler <j...@confluent.io> wrote: > Hi Maarten, > > Congratulations, your KIP has 3 binding votes, no vetoes, and has been open > for over 72 hours, so you can close the vote and submit a PR for review! > > The way to close the vote is you just reply to this thread and tally up the > votes, and say that the KIP vote has passed (see the other vote threads for > examples). Then, you can update: > * your KIP wiki to change the status to "Adopted" > * the main KIP page to move your KIP to the "Adopted" section (It should be > in the "under discussion" section > * the Kafka Streams page, to move your KIP to the "Adopted" section ( > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams) > > Looking forward to the PR! > > -John > > On Thu, Apr 18, 2019 at 7:58 PM Matthias J. Sax <matth...@confluent.io> > wrote: > >>Thanks a lot for the KIP! >> >> >> +1 (binding) >> >> >> -Matthias >> >> On 4/18/19 12:31 PM, Guozhang Wang wrote: >> > +1 (binding). >> > >> > Thanks. >> > >> > On Thu, Apr 18, 2019 at 10:48 AM John Roesler <j...@confluent.io> wrote: >> > >> >> Thanks, Maarten! >> >> >> >> +1 (non-binding) >> >> >> >> -John >> >> >> >> On Wed, Apr 17, 2019 at 1:45 PM Bill Bejeck <bbej...@gmail.com> wrote: >> >> >> >>> Thanks for the KIP. >> >>> >> >>> +1(binding) >> >>> >> >>> -Bill >> >>> >> >>> On Wed, Apr 17, 2019 at 12:58 PM Bruno Cadonna <br...@confluent.io> >> >> wrote: >> >>> >> >>>> Hi Maarten Duijn, >> >>>> >> >>>> Thank you for driving this. >> >>>> >> >>>> +1 (non-binding) >> >>>> >> >>>> Best, >> >>>> Bruno >> >>>> >> >>>> On Wed, Apr 17, 2019 at 8:21 AM Maarten Duijn <maartendu...@msn.com> >> >>>> wrote: >> >>>> >> >>>>> Hello all, >> >>>>> >> >>>>> There has been informal agreement so I would like to call for a vote >> >> on >> >>>>> KIP-446: Add changelog topic configuration to KTable suppress. This >> >>> will >> >>>>> allow users to configure internal topics created by the suppress >> >>> operator >> >>>>> via the streams DSL. >> >>>>> >> >>>>> KIP: >> >>>>> >> >>>> >> >>> >> >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-446%3A+Add+changelog+topic+configuration+to+KTable+suppress >> >>>>> JIRA: https://issues.apache.org/jira/browse/KAFKA-8147< >> >>>>> https://issues.apache.org/jira/browse/KAFKA-8029> >> >>>>> PR: will follow shortly >> >>>>> >> >>>>> Cheers, >> >>>>> Maarten >> >>>>> >> >>>> >> >>> >> >> >> > >> > >> >>
