Hi M. Manna, I left a review. Take a look.
Sorry for the delays. best, Colin On Mon, Jul 8, 2019, at 14:38, M. Manna wrote: > Hello, > > A few requests have been sent already. Could this please be reviewed ? Our > business implementation is holding due to this change. > > > > On Thu, 4 Jul 2019 at 13:33, M. Manna <manme...@gmail.com> wrote: > > > https://github.com/apache/kafka/pull/6771 > > > > Could this be reviewed please ? > > > > On Wed, 3 Jul 2019 at 11:35, M. Manna <manme...@gmail.com> wrote: > > > >> https://github.com/apache/kafka/pull/6771 > >> > >> Bouncing both users and dev to get some activity going. We are waiting > >> for a while to get this KIP pr merged. > >> > >> Could someone please review? > >> > >> Thanks, > >> > >> On Sun, 30 Jun 2019 at 08:59, M. Manna <manme...@gmail.com> wrote: > >> > >>> https://github.com/apache/kafka/pull/6771 > >>> > >>> Hello, > >>> > >>> Could the above PR can be reviewed? This has been waiting for a long > >>> time. > >>> > >>> Just to mention, the package name should have "internal". Round-robin > >>> partitioning should have been supported without/without a key from the > >>> beginning. It provides user a guaranteed round-robin partitioning without > >>> having to regard for key values (e.g. null/not null). From our business > >>> side, this is a Kafka internal logic. Hence, the placement inside > >>> "internal" package. > >>> > >>> Thanks, > >>> > >> >
