Thanks for the test on Windows (unfortunately, we are mainly use Unix
system, but we have to install a VirtualBox or something to test some
changes on Windows).
The regression is important for windows users.
I revert my previous vote and put -1 now.
Regards
JB
On 11/21/2010 06:41 PM, Łukasz Dywicki wrote:
Hi All,
I checked the release. Everything is ok, but I found small issue in
client.bat configuration file. It doesn't work because there is placeholders
that are not replaced by Maven:
set CLASSPATH=%KARAF_HOME%\lib\bin\karaf-client.jar
set
CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\sshd\sshd-core\${sshd.v
ersion}\sshd-core-${sshd.version}.jar
set
CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\mina\mina-core\${mina.v
ersion}\mina-core-${mina.version}.jar
set
CLASSPATH=%CLASSPATH%;%KARAF_HOME%\system\org\apache\karaf\shell\org.apache.
karaf.shell.console\${project.version}\org.apache.karaf.shell.console-${proj
ect.version}.jar
Sorry but from me it's -1. I checked linux script and it looks fine. Issue
is strictly related to windows release - both build by hand and downloaded
from staging repository have same issue.
Debug output from maven says that these resources are filtered
[DEBUG] filering
D:\sources\karaf-2.1.2\assembly\src\main\filtered-resources\bin\client to
D:\sources\karaf-2.1.2\assembly\target\classes\bin\client
[DEBUG] file client.bat has a filtered file extension
Best regards,
Lukasz
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Hiram
Chirino
Sent: Sunday, November 21, 2010 1:12 PM
To: [email protected]
Subject: Re: [VOTE] Release Karaf version 2.1.2
+1
Regards,
Hiram
FuseSource
Web: http://fusesource.com/
On Sat, Nov 20, 2010 at 4:37 PM, Jamie G.<[email protected]> wrote:
Hi,
We resolved 8 issues in this release (may take some time for cwiki to
update with this page):
https://cwiki.apache.org/confluence/display/KARAF/Karaf+2.1.2+Release
Staging repository:
https://repository.apache.org/content/repositories/orgapachekaraf-017/
Release tags:
http://svn.apache.org/repos/asf/karaf/tags/karaf-2.1.2/
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)
This vote will be open for 72 hours.
