definitely +1; maybe we should also add at least some very general pax-exam/htmlunit tests to check if the basics still work. This should be quite simple since it's not much more than copy and adapting the integration tests of pax-wicket
Kind regards, Andreas On Fri, Aug 19, 2011 at 10:56, Jean-Baptiste Onofré <[email protected]> wrote: > Hi Charles, > > even if Karaf WebConsole is on sandbox for now, we should apply the same > way as we use for Karaf, and more generally in all Apache project. > > I mean that: > - any refactoring should require a kind of approval or at least discussion > with the people involved on the project. Just a quick e-mail [WebConsole] on > the dev mailing list could avoid a lot of wasted time > - before commiting, the dev should be sure that the build works and there > is no regression. > > Karaf WebConsole is an Apache project: it doesn't belong to one person, > it's a community effort. So, we should work in a community compliant manner. > > Just a quick reminder for all of us ;) > > Regards > JB > > > On 08/19/2011 10:42 AM, Charles Moulliard wrote: > >> Hi, >> >> with last commit on , the features list page does not work anymore >> >> WicketMessage: Unable to find component with id 'link' in >> [MarkupContainer [Component id = cell]]. This means that you declared >> wicket:id=link in your markup, but that you either did not add the >> component to your page at all, or that the hierarchy does not match. >> [markup = bundle://93.0:1/org/apache/**karaf/webconsole/karaf/** >> internal/feature/**FeaturesActionsPanel.html >> <wicket:panel >> xmlns:wicket="http://wicket.**apache.org<http://wicket.apache.org> >> "> >> <a href="#" wicket:id="link"> >> <img wicket:id="actionButton" alt="feature install button"/> >> </a> >> </wicket:panel>, index = 2, current = '<a href="#" wicket:id="link">' >> (line 2, column 5)] >> >> >> When people commit code, it is required that they check the >> functionalities if they works, otherwise don't commit !!! >> By the way the FeaturesActionsPanel page has disappeared and the >> images cannot be displayed as getImage is not longer called. >> >> Regards, >> >> Charles Moulliard >> >> Apache Committer >> >> Blog : http://cmoulliard.blogspot.com >> Twitter : http://twitter.com/cmoulliard >> Linkedin : >> http://www.linkedin.com/in/**charlesmoulliard<http://www.linkedin.com/in/charlesmoulliard> >> Skype: cmoulliard >> > > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com >
