As per the noted issues I'm cancelling this vote, and will pick up the patches, then re-cut.
Cheers, Jamie On Thu, Apr 5, 2012 at 7:34 AM, Jean-Baptiste Onofré <[email protected]> wrote: > Good point Andreas, > > My bad: I tested only the binaries. > > Agree to -1 (binding). > > In that case, we could: > - apply the Andreas' patch on src assemblies > - apply the Christian's patch on the start level > > Regards > JB > > > On 04/05/2012 12:00 PM, Andreas Pieber wrote: >> >> OK, typically I simply checkout the tag and check if the build is >> successfully there; then I check the locally build assemblies and try >> to run them. Finally I download the assemblies and also run them >> (besides the typical notice, keys, ... check). After all this had been >> successfully I upgrade my projects and test them too. >> >> OK, but after this discussion on general: "ASF releases are all about >> the source release and all other binary packages are >> non-apache-side-products-to-help-users" I've decided to give [1] a >> shot. And the tests fail -.- The problem is that .kar and .zip files >> are not handled as binary files in the src package scripts. But since >> deployer/kar tests have some zips/kar files those tests fail since the >> zis/kars are modified with line endings now... >> >> --> (a) I've attached the patch for now. I can create the issue and >> apply it. Any special things to consider since this is a RC? >> --> (b) Since the src release seams to be the only one to matter I've to >> do a... >> >> -1 (binding) >> >> ...vote :-( sorry guys. >> >> Kind regards, >> Andreas >> >> [1] >> https://repository.apache.org/content/repositories/orgapachekaraf-001/org/apache/karaf/apache-karaf/2.2.6/apache-karaf-2.2.6-src.tar.gz >> >> On Thu, Apr 5, 2012 at 10:39, Freeman Fang<[email protected]> wrote: >>> >>> +1 >>> >>> Thanks >>> Freeman >>> >>> On 2012-4-4, at 下午11:49, Jamie G. wrote: >>> >>>> Hi, >>>> >>>> We resolved 76 issues in this release (web page will be published post >>>> RC promotion): >>>> >>>> >>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.6-release.page >>>> >>>> Staging repository: >>>> https://repository.apache.org/content/repositories/orgapachekaraf-001/ >>>> >>>> Release tags: >>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.6/ >>>> >>>> Please vote to approve this release: >>>> >>>> [ ] +1 Approve the release >>>> [ ] -1 Veto the release (please provide specific comments) >>>> >>>> This vote will be open for 72 hours. >>> >>> >>> >>> --------------------------------------------- >>> Freeman Fang >>> >>> FuseSource >>> Email:[email protected] >>> Web: fusesource.com >>> Twitter: freemanfang >>> Blog: http://freemanfang.blogspot.com >>> http://blog.sina.com.cn/u/1473905042 >>> weibo: http://weibo.com/u/1473905042 >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> > > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com
