one more thing on this, please no more refactorings, all of the sudden stuff that did work and has been tested well starts to fall apart. This isn't supposed to happen, we had a pretty good code base here. We need to make sure a refactoring does really make sense and has a bigger benefit then the stuff that is already working, and just to cite Martin Fowler, the god of refactoring, those refactorings have to be accompanied by good unit tests that have been working before and after refactoring. Oh and just another thing, good refactorings are done in small steps ....
http://martinfowler.com/refactoring/ regards, Achim 2012/4/12 Jean-Baptiste Onofré <[email protected]>: > Agree with you both guys. > > I'm working on the issue. I will keep you posted soon. > > Regards > JB > > > On 04/12/2012 02:33 PM, Jamie G. wrote: >> >> A 2.2.7 would make more sense to me -- just need to start one soon. >> >> Cheers, >> Jamie >> >> On Thu, Apr 12, 2012 at 8:27 AM, Jean-Baptiste Onofré<[email protected]> >> wrote: >>> >>> Hi guys, >>> >>> In Karaf 2.2.6, in order to improve the ConfigAdmin management (using >>> config:* commands and ConfigMBean), we changed the way to handle >>> configuration files and flush on the storage. >>> >>> It leads to a "critical" regression where the ConfigAdmin update are not >>> flushed into the configuration file: >>> https://issues.apache.org/jira/browse/KARAF-1360 >>> >>> I'm gonna take a look on this issue and fix it asap. >>> >>> I just wonder if: >>> - it makes sense to release a 2.2.6.1 (a kind of hotfix release) >>> - it makes sense to wait 2.2.7 but we should cut off this release very >>> soon >>> >>> WDYT ? >>> >>> Regards >>> JB >>> -- >>> Jean-Baptiste Onofré >>> [email protected] >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com > > > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com -- Apache Karaf <http://karaf.apache.org/> Committer & PMC OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead blog <http://notizblog.nierbeck.de/>
