Btw, I don't think there's a need to open new JIRA give KARAF-647 is still in progress.
On Wed, May 23, 2012 at 3:18 PM, Guillaume Nodet <[email protected]> wrote: > Not sure, I haven't looked at how the subshells are implemented yet, > but I suppose it modifies the session variable SCOPE to reduce the > default commands set. > I would think that the current subshell scope should be added to the > beginning of that list instead of at the end (if that's how it works). > > For the admin:connect, the ssh command is launched as a string, so > replacing ssh with ssh:ssh should make the trick. > > On Wed, May 23, 2012 at 3:09 PM, Christian Schneider > <[email protected]> wrote: >> I also encountered these bugs but was not sure how to fix that. >> >> Can you open a jira issue? If you have any ideas how to solve it I can do >> the implementation. >> >> Christian >> >> Am 23.05.2012 14:29, schrieb Guillaume Nodet: >> >>> I've seen a couple of problems in trunk with subshells: >>> >>> karaf@root()> instance >>> karaf@root(instance)> list >>> >>> that one executes bundle:list instead of instance:list. I suppose the >>> scope is not correctly updated. >>> >>> karaf@root()> admin:connect foo >>> >>> this one fails because ssh is not the command anymore, but rather the >>> shell. I guess it can easily be fixed by using ssh:ssh instead. >>> >>> On Tue, May 22, 2012 at 2:11 PM, Guillaume Nodet<[email protected]> wrote: >>>> >>>> The help command does that afaik. I'd keep the real completion for >>>> everything, not only for subshells. >>>> >>>> On Tue, May 22, 2012 at 2:07 PM, Christian Schneider >>>> <[email protected]> wrote: >>>>> >>>>> I understand but I still think a cd command could help. At the very >>>>> least it >>>>> would allow command completion for subshells. >>>>> Currently if you want a hint which subshell to choose you can only type >>>>> tab >>>>> which shows 242 commands. >>>>> >>>>> With cd<tab> you would see only the subshells which should be around 10 >>>>> which would give the user a much better overview. >>>>> >>>>> So an idea would be to add the cd command without removing the geneated >>>>> subshell commands. >>>>> >>>>> Btw. I think we could also improve the completion list shown by simply >>>>> typing<tab>. If we only show the scope of commands with scope that would >>>>> make the list a lot smaller. >>>>> When you then type the whole scope we could show the commands in the >>>>> scope. >>>>> >>>>> Christian >>>>> >>>>> Am 22.05.2012 13:21, schrieb [email protected]: >>>>> >>>>>> As reminder, the purpose is to have IoS like shell console. That's why >>>>>> we >>>>>> don't have cd command. >>>>>> >>>>>> -- >>>>>> Jean-Baptiste Onofré >>>>>> [email protected] >>>>>> http://blog.nanthrax.net >>>>>> Talend - http://wwx.talend.com >>>>>> >>>>>> ----- Reply message ----- >>>>>> From: "Christian Schneider (JIRA)"<[email protected]> >>>>>> To:<[email protected]> >>>>>> Subject: [jira] [Commented] (KARAF-647) Support of sub-shell >>>>>> Date: Tue, May 22, 2012 12:14 pm >>>>>> >>>>>> >>>>>> >>>>>> [ >>>>>> >>>>>> https://issues.apache.org/jira/browse/KARAF-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280861#comment-13280861 >>>>>> ] >>>>>> >>>>>> Christian Schneider commented on KARAF-647: >>>>>> ------------------------------------------- >>>>>> >>>>>> I just reviewed the prototype. What I don´t like is the auto generation >>>>>> of >>>>>> commands to enter the subshells. >>>>>> I would prefer to have a single command like cd<subshellname> to >>>>>> enter >>>>>> subshells. This is much simpler >>>>>> to implement and allows even better completion as the completion then >>>>>> will >>>>>> only show scopes. >>>>>> >>>>>> It also allows to extend the concept to the resource model I proposed >>>>>> above as we have more freedom what to do when cd is called then >>>>>> having single sommands for each subshell. >>>>>> >>>>>>> Support of sub-shell >>>>>>> -------------------- >>>>>>> >>>>>>> Key: KARAF-647 >>>>>>> URL: https://issues.apache.org/jira/browse/KARAF-647 >>>>>>> Project: Karaf >>>>>>> Issue Type: New Feature >>>>>>> Components: karaf-shell >>>>>>> Reporter: Jean-Baptiste Onofré >>>>>>> Assignee: Jean-Baptiste Onofré >>>>>>> Fix For: 3.0.0 >>>>>>> >>>>>>> >>>>>>> Thanks the high Karaf adoption level, we have projects that provide >>>>>>> Karaf >>>>>>> shell commands. >>>>>>> For instance, Camel provides Karaf commands, like ACE, CXF, >>>>>>> ServiceMix, >>>>>>> etc do. >>>>>>> It could be helpful to have a kind of sub-shells, similar to the Cisco >>>>>>> IoS shell: >>>>>>> karaf@root> camel >>>>>>> karaf@root:camel> route:list >>>>>>> karaf@root:camel> route:stop >>>>>>> karaf@root:camel> exit >>>>>>> karaf@root> ace >>>>>>> karaf@root:ace> distribution:list >>>>>>> karaf@root:ace> exit >>>>>> >>>>>> -- >>>>>> This message is automatically generated by JIRA. >>>>>> If you think it was sent incorrectly, please contact your JIRA >>>>>> administrators: >>>>>> >>>>>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >>>>>> For more information on JIRA, see: >>>>>> http://www.atlassian.com/software/jira >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Christian Schneider >>>>> http://www.liquid-reality.de >>>>> >>>>> Open Source Architect >>>>> Talend Application Integration Division http://www.talend.com >>>>> >>>> >>>> >>>> -- >>>> ------------------------ >>>> Guillaume Nodet >>>> ------------------------ >>>> Blog: http://gnodet.blogspot.com/ >>>> ------------------------ >>>> FuseSource, Integration everywhere >>>> http://fusesource.com >>> >>> >>> >> >> >> -- >> Christian Schneider >> http://www.liquid-reality.de >> >> Open Source Architect >> Talend Application Integration Division http://www.talend.com >> > > > > -- > ------------------------ > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > FuseSource, Integration everywhere > http://fusesource.com -- ------------------------ Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ FuseSource, Integration everywhere http://fusesource.com
