TBH, I still think changing the failing "Test" is cheating therefore I rather have a not successful test then "shooting the messenger"
Achim 2012/5/30 Christian Schneider <[email protected]>: > To me the deployer demo looks strange. If you look at the pom: > <modules> > <module>src/main/resources/resources/demos/deployer/kar</module> > <module>src/main/resources/resources/demos/deployer/bundle</module> > </modules> > > I have never seen before that modules reside inside a src/main/resources > dir. So this may be the cause of the build failure. > > So I would like to consult Jamie who wrote this before reverting and > breaking the build again. I hope you agree that this is better than simply > reverting and sacrificing a working build. > > Christian > > Am 30.05.2012 11:44, schrieb Achim Nierbeck: > >> No, strongly disagree. >> Since we don't have a full set of itests I consider our demos to be >> part of those. >> So it's more crucial to fix the cause of the failing demo then >> disabling the demo! >> >> Achim >> >> 2012/5/30 Christian Schneider<[email protected]>: >>> >>> I think to fix the build is the higher priority. So if this makes the >>> build >>> work again I happilly live without a single demo for some time till >>> we fix the cause. >>> >>> Christian >>> >>> Am 30.05.2012 11:20, schrieb Achim Nierbeck: >>> >>>> -1 please fix the cause not shoot the messenger >>>> >>>> 2012/5/30<[email protected]>: >>>>> >>>>> Author: cschneider >>>>> Date: Wed May 30 09:18:34 2012 >>>>> New Revision: 1344165 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=1344165&view=rev >>>>> Log: >>>>> KARAF-1509 Disabling the deployer demo for the moment as the build >>>>> fails >>>>> there >>>>> >>>>> Modified: >>>>> karaf/trunk/demos/pom.xml >>>>> >>>>> Modified: karaf/trunk/demos/pom.xml >>>>> URL: >>>>> >>>>> http://svn.apache.org/viewvc/karaf/trunk/demos/pom.xml?rev=1344165&r1=1344164&r2=1344165&view=diff >>>>> >>>>> >>>>> ============================================================================== >>>>> --- karaf/trunk/demos/pom.xml (original) >>>>> +++ karaf/trunk/demos/pom.xml Wed May 30 09:18:34 2012 >>>>> @@ -38,7 +38,9 @@ >>>>> <module>branding</module> >>>>> <module>command</module> >>>>> <module>dump</module> >>>>> +<!-- Disabling this for the moment as the build fails at the >>>>> my-kar.pom >>>>> <module>deployer</module> >>>>> + --> >>>>> </modules> >>>>> >>>>> </project> >>>>> >>>>> >>>> >>> >>> -- >>> Christian Schneider >>> http://www.liquid-reality.de >>> >>> Open Source Architect >>> Talend Application Integration Division http://www.talend.com >>> >> >> > > > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > Talend Application Integration Division http://www.talend.com > -- Apache Karaf <http://karaf.apache.org/> Committer & PMC OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead OPS4J Pax for Vaadin <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project Lead blog <http://notizblog.nierbeck.de/>
