It won't be sufficient I think as the code will throw a CNFE and the console won't start. But that needs to be catched and a message logged imho.
On Fri, Sep 21, 2012 at 10:21 AM, Jean-Baptiste Onofré <[email protected]>wrote: > Basically, it was my question ;) > > I try to set org.apache.sshd.agent package as optional (it's used in the > ConsoleFactory) to see if it works. > > Thanks, > Regards > JB > > > On 09/21/2012 10:12 AM, Guillaume Nodet wrote: > >> This dependency should really be optional, so I think flagging the >> imported >> package on sshd as optional and making sure that the code can handle the >> abscence of the package could be a way to go. >> >> On Fri, Sep 21, 2012 at 10:07 AM, Jean-Baptiste Onofré <[email protected] >> >wrote: >> >> Hi guys, >>> >>> I saw that the minimal distribution didn't start correctly on Karaf 2.3.x >>> branch. >>> >>> The problem is due to a dependency that we introduced in shell console to >>> add the ssh agent support. Now, shell console depends to sshd. >>> >>> In the "normal" distribution, mina-core, sshd and shell.ssh are in the >>> startup.properties. >>> >>> If we put these bundles in startup.properties, I wonder if it makes sense >>> to have a ssh feature: even if an user removes the ssh feature from >>> bootFeature, the ssh stuff will be there as started by the >>> startup.properties. >>> >>> For now, I'm fixing the minimal distribution updating the >>> startup.properties, but I would like to have your feedback about that. >>> >>> Regards >>> JB >>> -- >>> Jean-Baptiste Onofré >>> [email protected] >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com >>> >>> >> >> >> > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com > -- ------------------------ Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ FuseSource, Integration everywhere http://fusesource.com
