Hi Jean-Baptiste, That's right, sorry for the mistake.
I will make a new setup from scratch, verify the issue and open a ticket if it is still there. Regards, On Fri, Dec 13, 2013 at 2:39 AM, Jean-Baptiste Onofré <[email protected]>wrote: > Hi Fernando, > > KARAF-1319 was about the fact that you don't have any message explaining > why a group can't be deleted. > > As I said, if default doesn't contain any node, you should be able to > delete it. > However, if you have at least one node in the default cluster group, you > can execute cluster:group-delete but it has no effect (and you don't have > error message). > > Regards > JB > > > On 12/12/2013 10:32 PM, Fernando Ribeiro wrote: > >> Hi Jean-Baptiste, >> >> Just realized this issue has already been reported in KARAF-1319, which is >> currently marked as resolved. >> >> Regards, >> >> >> On Thu, Dec 12, 2013 at 7:09 PM, Fernando Ribeiro < >> [email protected]> wrote: >> >> Hi Jean-Baptiste, >>> >>> Even though that change has fixed the configuration saving, which was >>> also >>> an issue, I still can't delete the default cluster group, and found the >>> reason in the HazelcastGroupManager class: >>> >>> public void deleteGroup(String groupName) { >>> ClassLoader originalClassLoader = >>> Thread.currentThread().getContextClassLoader(); >>> >>> try { >>> Thread.currentThread().setContextClassLoader(combinedClassLoader); >>> if (!groupName.equals(Configurations.DEFAULT_GROUP_NAME)) { >>> listGroups().remove(groupName); >>> try { >>> // store the group list to configuration admin >>> persist(listGroups()); >>> } catch (Exception e) { >>> LOGGER.warn("CELLAR HAZELCAST: can't store group list", e); >>> } >>> } >>> } finally { >>> Thread.currentThread().setContextClassLoader(originalClassLoader); >>> } >>> } >>> >>> I can take care of the PR if you can confirm that it is really not the >>> expected behavior. >>> >>> Regards, >>> >>> >>> >>> On Thu, Dec 12, 2013 at 6:16 PM, Jean-Baptiste Onofré <[email protected] >>> >wrote: >>> >>> On Karaf 2.3.3, in the etc/config.properties, do you have: >>>> >>>> felix.fileinstall.enableConfigSave = true >>>> >>>> and NOT >>>> >>>> felix.fileinstall.enableConfigSave = false >>>> >>>> It's bug that we introduced (and it will be fixed in 2.3.4 and next >>>> releases). We should never have changed this to false, this property >>>> should >>>> be set to true. >>>> >>>> This property sets to false block the cfg update, that's why Cellar >>>> can't >>>> update the groups set. >>>> >>>> Regards >>>> JB >>>> >>>> >>>> On 12/12/2013 09:13 PM, Fernando Ribeiro wrote: >>>> >>>> Hi Jean-Baptiste, >>>>> >>>>> Actually I can't delete it in Karaf 2.3.3 with Cellar 2.3.2, even >>>>> though >>>>> the command doesn't fail and nothing is written to the log, can you >>>>> please >>>>> verify? >>>>> >>>>> Regards, >>>>> >>>>> >>>>> >>>>> On Thu, Dec 12, 2013 at 6:07 PM, Jean-Baptiste Onofré <[email protected] >>>>> >>>>>> wrote: >>>>>> >>>>> >>>>> Hi Fernando, >>>>> >>>>>> >>>>>> Cellar needs at least one cluster group. If you have only default, it >>>>>> can't be removed. >>>>>> >>>>>> If you create another cluster group and move all nodes in this group, >>>>>> in >>>>>> that case, you will be able to delete default cluster group. >>>>>> >>>>>> Regards >>>>>> JB >>>>>> >>>>>> >>>>>> On 12/12/2013 08:58 PM, Fernando Ribeiro wrote: >>>>>> >>>>>> Hello, >>>>>> >>>>>>> >>>>>>> Is there any particular reason why the default cluster group can't be >>>>>>> deleted and/or renamed? >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>> Jean-Baptiste Onofré >>>>>> [email protected] >>>>>> http://blog.nanthrax.net >>>>>> Talend - http://www.talend.com >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>> Jean-Baptiste Onofré >>>> [email protected] >>>> http://blog.nanthrax.net >>>> Talend - http://www.talend.com >>>> >>>> >>> >>> >>> -- >>> Fernando Ribeiro >>> Upic >>> +55 11 9 8111 4078 >>> >>> >> >> >> > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com > -- Fernando Ribeiro Upic +55 11 9 8111 4078
