On 05.03.2014 13:10, Guillaume Nodet wrote:
I think ActiveMQ might be a good case for using an extended gogo api.
Not sure to follow. They're currently using the old api and
implementation, so they do work unchanged (I've actually fixed a few things
in the compatibility layer and tested against ActiveMQ).
If ActiveMQ were to migrate, there would be multiple choices:
* using the new action model: given the small number of commands (6),
it's something that can be done. It would mean implementing real Action to
leverage completion and help and then
rebuild the command line and execute the native action inside the
execute() method
* using the console level Command model: activemq does not need to
implement actions at all and can directly wrap
native actions into this interface. Activemq would be responsible
for providing a completer if wanted, but it's not even currently available
* using plain gogo as now : we just need to make those gogo commands
supported in the console (which isn't done yet, but fairly easy to do)
but there would be no way to provide completion (but there's none
currently anyway). It would be roughly similar to the above, without the
ability to provide completion
* the last option which is what you hint about first needs an extended
api and then support in karaf. It's currently not an option as this is not
yet implemented
but it could definitely be considered when available
ActiveMQ is not urgent but we need a solution before karaf 4 as we would
like to remove the old API then.
So perhaps we have enough time for a good gogo support. If not then one
of the other options will work.
Christian
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
