Hello
-1 (non-binding)
I did a full build from `karaf-2.4.0` tag using JDK8. It wouldn't be
however possible with this diff:
```
diff --git a/tooling/features-maven-plugin/pom.xml
b/tooling/features-maven-plugin/pom.xml
index 8d9d46d..42cc35b 100644
--- a/tooling/features-maven-plugin/pom.xml
+++ b/tooling/features-maven-plugin/pom.xml
@@ -59,6 +59,11 @@
<artifactId>maven-bundle-plugin</artifactId>
</dependency>
<dependency>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>org.apache.felix.fileinstall</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
<groupId>org.apache.karaf.features</groupId>
<artifactId>org.apache.karaf.features.core</artifactId>
<exclusions>
```
I had to add this provided dependency, because the same dependency from
`org.apache.karaf.deployer.kar` artifact is not transitive and not visible
during compilation of `features-maven-plugin` artifact.
I was using Maven 3.2.3.
After the fix in dependencies entire build and all tests passed OK.
regards
Grzegorz Grzybek
2014-09-17 21:55 GMT+02:00 Achim Nierbeck <[email protected]>:
> +1 (binding)
>
> regards, Achim
>
>
> 2014-09-17 19:57 GMT+02:00 Krzysztof Sobkowiak <[email protected]
> >:
>
> > +1 (non-binding). Good job
> >
> > Regards
> > Krzysztof
> >
> > On 17.09.2014 17:43, Jamie G. wrote:
> > > Hi,
> > >
> > > We resolved 441 issues in this release:
> > >
> >
> http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.4.0-release.page?view=markup
> > >
> > > A Dependencies table will be created to track changes on the 2.4.x
> > series.
> > >
> > > Staging repository:
> > >
> https://repository.apache.org/content/repositories/orgapachekaraf-1011/
> > >
> > > Git tag:
> > > karaf-2.4.0
> > >
> > > Please vote to approve this release:
> > >
> > > [ ] +1 Approve the release
> > > [ ] -1 Veto the release (please provide specific comments)
> > >
> > > This vote will be open for 72 hours.
> >
> >
> > --
> > Krzysztof Sobkowiak
> >
> > JEE & OSS Architect | Senior Solution Architect @ Capgemini | Committer
> > @ ASF
> > Capgemini <http://www.pl.capgemini.com/> | Software Solutions Center
> > <http://www.pl.capgemini-sdm.com/> | Wroclaw
> > e-mail: [email protected] <mailto:[email protected]> |
> > Twitter: @KSobkowiak
> > Calendar: http://goo.gl/yvsebC
> >
>
>
>
> --
>
> Apache Member
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
> Project Lead
> blog <http://notizblog.nierbeck.de/>
>
> Software Architect / Project Manager / Scrum Master
>
