GitHub user kemitix opened a pull request:
https://github.com/apache/karaf/pull/299
Refactoring AssemblyMojo
`AssemblyMojo` is a 580 line file with a single 257-line method accounting
for the bulk of it. It also has no unit tests.
This creates system tests for `AssemblyMojo` and refactors it into a more
manageable structure, all within a new `assembly` package, with suitable unit
tests. Code coverage is 100% from either the system tests or the unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kemitix/karaf assembly-mojo-refactoring-4.2.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/karaf/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit 92070eac8fb2f575603cdc0e342e9db74b217b48
Author: Paul Campbell <[email protected]>
Date: 2017-04-11T17:50:07Z
tooling.karaf-maven-plugin: pom.xml: jacoco coverage reporting
commit 9fb0a7ffc6cbc9914d231b856cbecdff5738f76d
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T18:48:37Z
tooling.karaf-maven-plugin: pom.xml: disable code coverage minimums
commit c7db1f2e610442ffefb1c5333ee11f67b11cb2e5
Author: Paul Campbell <[email protected]>
Date: 2017-04-11T21:33:26Z
pom.xml: Specify maven versions in properties
maven-project is pinned at 2.0.9, separate from maven.version as the
tooling module updates to maven 3.x which does not have a
maven-project.
Even though maven-project doesn't appear to be used and should
probably be removed, not pinning the version in dependencyManagement
will cause mvn to fail with an unresolved artifact.
commit 5fe71b927d8060c8a3bbe0f8749c092aaff28fff
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T06:05:47Z
tooling.karaf-maven-plugin: Add maven-plugin-test-harness
commit 70454fdc074faaef56cca62e61445b157a7bcf1f
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T12:59:37Z
tooling: Upgrade maven to 3.5.0
commit 7facdada9aa0efe56fbf422ab30dac64517a8e39
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T18:32:34Z
tooling.karaf-maven-plugin: DependencyHelperFactory: only support Maven 3.1+
commit bb101b42d18519bded5ac3ef715f6bd3d76ee4ea
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T18:36:54Z
tooling.karaf-maven-plugin: Dependency30Helper removed
Updated MavenUtilTest
commit 1cfce1e4c8c076fd265864fb8b8eff30ab40ad3b
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T19:05:55Z
tooling.karaf-maven-plugin: Upgrade plexus-utils to 3.0.21
commit ec273c54e6a8d9053e3af34409cf7cc51a41c708
Author: Paul Campbell <[email protected]>
Date: 2017-04-12T19:08:03Z
[WIP] tooling.karaf-maven-plugin: shouldExecuteMojo
commit 81bb160ba5c733e6871c64c1aa64de55723313f8
Author: Paul Campbell <[email protected]>
Date: 2017-04-14T21:19:02Z
tooling.karaf-maven-plugin: Add assertj dependency
commit f6f8b5941e01f963385e1f2db59bdc9d0c422375
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T07:15:35Z
tooling.karaf-maven-plugin: extract AssemblyMojoExec from AssemblyMojo
Extracts the doExecute() method into it's own class, passing in
AssemblyMojo as a parameter, addorned with suitable set/get methods.
commit 3362b13d31db003fc1f8166c6babd633341430fc
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T07:25:46Z
tooling.karaf-maven-plugin: initial test passes
commit 6d2df2e8600a8512f102c67933070da910b87bb1
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T13:14:34Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: refactor as
getAssemblyMojo()
commit 444650d2fb2f18c30e6028887b4a7d64cb5505b9
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T13:16:34Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: create setUp
commit 59d96d863c9ea9cdf30eb6f1a9c71737bb8ec449
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T13:29:57Z
pom.xml: make mockito 1.10.19 available as a dependency
commit 4948338541cf68a3d4367bd0cd54a02a7c026ace
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T13:37:58Z
tooling.karaf-maven-plugin: pom.xml: use mockito
commit b7e678407a1c13527d346c9c37876ece86362ac7
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T13:38:31Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: replace MyBuilder with
@Spy
commit 99edc508c6a203bc51f9ce0baa9727334d27e137
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T13:46:15Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: refactor getAssemblyMojo
commit cbd258c0a2627b5f7ce1b1db9a5aa5bb03ef2dfa
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T14:01:17Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: add test dependencies
commit b2e4b2a65d2a748267d16d110dff2fd0cdad3871
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T16:29:39Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: test added dependencies,
profiles and features
commit 00ec64a748cc72c072565f0e58a01a27d84f8202
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T18:18:41Z
tooling.karaf-maven-plugin: AssembltMojoExecTest: clean up
commit 6f62762a8a61a8d5cebd79b32191f1d903c122f4
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T18:24:53Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: test with alternate
frameworks
commit 85bb1b5c298f9c71a3d749f94a9ac9b5c135ec14
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T18:31:00Z
pom.xml: make hamcrest available
commit 0c2c392f2c328e4dd93a6756986f85fae9dc7481
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T18:31:25Z
tooling.karaf-maven-plugin: pom.xml: add hamcrest dependency
commit 6e7b9f273c415326f636d96c8ae81853f4990318
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T18:31:51Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: test for invalid framework
commit 17af52c3fb80be7485992a2b1ed1a9d5c435f80a
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T19:07:37Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: tests for when
profileDirectory is required
commit e3eca647bd7851c47b0a8d439a28baa0c93e46eb
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T21:27:00Z
tooling.karaf-maven-plugin: AssemblyMojoExec: break up shouldExecuteMojo
Split into individual tests for each type of dependency.
commit 15fe07cc8a3205ccd1a662b03d8281aff238d2d5
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T21:35:06Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: constant is private
commit 02f694cab814c7789fb9be65acca86586e588788
Author: Paul Campbell <[email protected]>
Date: 2017-04-15T21:43:39Z
tooling.karaf-maven-plugin: AssemblyMojoExecTest: clean up
commit 8e247c9650538f0440679f83434076779c2af674
Author: Paul Campbell <[email protected]>
Date: 2017-04-16T07:48:49Z
tooling.karaf-maven-plugin: test feature and maven repos
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
