GitHub user llech opened a pull request:

    https://github.com/apache/karaf/pull/315

    Openssh keygen fix

    When no SSH key was present, a key was generated. Unfortunately, the write 
method was incompatibile with read, and such key could not be read on next 
start, which generated issues such as:
    
https://stackoverflow.com/questions/43070457/stop-karaf-from-generating-new-ssh-keys-on-startup
    
    I've fixed the key persisting and provided JUnit test that checks if that 
what was written can be read. Previous 'test' has only tested if an exception 
was thrown. Because an exception was consumed, the 'test' was passed although 
the read has failed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/llech/karaf openssh-keygen-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #315
    
----
commit 1ebec4f4f59e3aee381b9f3ceccd3fe89e136cd3
Author: Lukasz Lech <[email protected]>
Date:   2017-03-30T08:29:05Z

    Fix for OpenSSHGeneratorKeyFileProvider writeSshKey method: JUnit test to 
assert the class can read what was previously written

commit 48e5f55045f3a4a882af310d91d820bbbf7e65b8
Author: Lukasz Lech <[email protected]>
Date:   2017-04-28T11:30:15Z

    Merge branch 'master' of https://github.com/apache/karaf

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to