Hi JB,
The plugins works well (just tested on Vineyard) and I can see that we
can add the license header in the plugin configuration :
<licenseHeader>
<!-- Specify either content or file, but not both -->
<content>/* Licensed under Apache-2.0 */</content>
<file>${basedir}/license-header</file>
</licenseHeader>
Should we add this ?
regards,
François Papon
[email protected]
Le 08/11/2018 à 08:54, Jean-Baptiste Onofré a écrit :
> Hi guys,
>
> I updated the PR to use a 4 spaces indent style.
>
> Regards
> JB
>
> On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
>> Hi team,
>>
>> I created a PR (https://github.com/apache/karaf/pull/648) to enable
>> spotless in Karaf.
>>
>> Spotless is code style checker but also formatter.
>>
>> The spotless profile I added in the PR check the style and the style can
>> be automatically fixed using mvn spotless:apply -Pspotless.
>>
>> I think it would be great to have this in Karaf and subprojects to have
>> a consistency in our code style.
>>
>> In combination with rat, it gives us a much cleaner code.
>>
>> On the other hand, I was planning to add findbugs maven plugin as well.
>>
>> Thoughts ?
>>
>> Thanks,
>> Regards
>> JB
>>
