Hi Julian, about zip/tar.gz, I don't mind to provide only tar.gz as soon as it also provides the bat files ;)
For the source, you should use -src classifier tar.gz/zip, those ones should not have any jar files. About the "binary" files, it's apache-karaf-xxx.tar.gz|zip as state on the website (http://karaf.apache.org/download.html). I will update the vote e-mail for next cycle. Regards JB On 25/09/2019 14:54, Julian Feinauer wrote: > Hi all, > > finally found some time to check the release. > > +1 (non-binding), see some comments of (non-major) issues I found below. > > I did > > - Checked all signatures and hashes > - Unzipped tar.gz (see below) > - Build karaf with instructions from README (`mvn clean install`) on macOs > Mojave with java 1.8. > - Checked LICENSE and NOTICE files in all archives > - Checked no unexpected jars in the folders (see below) > > Issues: > - I find the structure very confusing with providing tar.gz AND zip. Nowadays > both should work on all systems, so I suggest to reduce that > - There are many jars in the apache-karaf-4.2.7 source folder. I guess they > are needed (for what?) but I did not find any notice of those in the README > or the NOTICE file. Is this not necessary? As I was surprised to find jars in > there. > > Very Minor Issue: > - It was not clear for me what the source release was and what the > "convenience binaries" where. So I Suggest to state that more explicit in the > Vote Mails (and later in the download section ofc). It may be obvious for > Karaf-Veterans but its confusing for newcomers (and every project should LOVE > newcomers : > ) > > Am 24.09.19, 14:33 schrieb "Jean-Baptiste Onofré" <j...@nanthrax.net>: > > Not for long ;) Unomi will jump to 4.2.x very soon ;) > > Thanks Serge ! > > Regards > JB > > On 24/09/2019 14:29, Serge Huber wrote: > > I would love to test and validate this with Apache Unomi but I'm still > on > > Karaf 4.1.x :) > > > > So +1 (non-binding). > > > > cheers, > > Serge... > > > > On Tue, Sep 24, 2019 at 1:30 PM Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > >> Hi Grzegorz, > >> > >> yeah, I already identified those differences. We will address in next > >> releases, but no impact. > >> > >> Regards > >> JB > >> > >> On 24/09/2019 13:08, Grzegorz Grzybek wrote: > >>> +1 > >>> > >>> And a report from assemblies/apache-karaf/target/bundle-report.xml: > >>> > >>> - pax-web 7.2.11 uses commons-codec 1.11, while Karaf uses 1.13 > >>> - hibernate validator 6.0.17.Final uses javax.annotation-api/1.2, > while > >>> Karaf and pax-web use 1.3 > >>> - pax-web 7.2.11 uses > >>> > mvn:org.apache.aries.spifly/org.apache.aries.spifly.dynamic.bundle/1.2, > >>> while Karaf uses 1.2.2 > >>> - pax-jdbc 1.4.0 uses geronimo-connector/3.1.1 while Karaf uses > >>> geronimo-connector/3.1.4 > >>> - pax-cdi 1.1.1 uses xbean-bundleutils 4.12, while pax-web 7.2.11 > uses > >> 4.14 > >>> > >>> but these are minor differences. > >>> > >>> regards > >>> Grzegorz Grzybek > >>> > >>> > >>> wt., 24 wrz 2019 o 11:28 Andrea Cosentino > <ancosen1...@yahoo.com.invalid > >>> > >>> napisał(a): > >>> > >>>> +1 (non-binding) > >>>> > >>>> Thanks JB > >>>> > >>>> -- > >>>> Andrea Cosentino > >>>> ---------------------------------- > >>>> Apache Camel PMC Chair > >>>> Apache Karaf Committer > >>>> Apache Servicemix PMC Member > >>>> Email: ancosen1...@yahoo.com > >>>> Twitter: @oscerd2 > >>>> Github: oscerd > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> On Monday, September 23, 2019, 6:35:20 PM GMT+2, Jean-Baptiste > Onofré < > >>>> j...@nanthrax.net> wrote: > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> Hi all, > >>>> > >>>> I submit Apache Karaf (runtime) 4.2.7 to your vote. This is a > >>>> maintenance release on the 4.2.x series, bringing updates, > improvements > >>>> and fixes (client.bat on Windows, config fileinstall reuse, race > >>>> condition on config in some activator, ...). > >>>> > >>>> Release Notes: > >>>> > >>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12345539 > >>>> > >>>> Staging Repository: > >>>> > https://repository.apache.org/content/repositories/orgapachekaraf-1133/ > >>>> > >>>> Git Tag: > >>>> karaf-4.2.7 > >>>> > >>>> Please vote to approve this release: > >>>> > >>>> [ ] +1 Approve the release > >>>> [ ] -1 Don't approve the release (please provide specific comments) > >>>> > >>>> This vote will be open for at least 72 hours. > >>>> > >>>> Thanks, > >>>> Regards > >>>> JB > >>>> -- > >>>> Jean-Baptiste Onofré > >>>> jbono...@apache.org > >>>> http://blog.nanthrax.net > >>>> Talend - http://www.talend.com > >>>> > >>> > >> > >> -- > >> Jean-Baptiste Onofré > >> jbono...@apache.org > >> http://blog.nanthrax.net > >> Talend - http://www.talend.com > >> > > > > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com > > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
