+1 Cheers, Jamie
On Wed, Apr 1, 2020 at 12:07 PM Francois Papon <francois.pa...@openobject.fr> wrote: > > Sounds good. > > +1 to keep the release going. > > regards, > > François > fpa...@apache.org > > Le 01/04/2020 à 16:14, Jean-Baptiste Onofre a écrit : > > OK, I figured out how to reproduce: it’s really a race condition: if > > testTracer() is executed before testTracerWithExtender() then it’s not > > to2_log but to1_log. > > > > I propose to fix the test on master (for 2.4.0) but keep the release going. > > > > OK ? > > > > Regards > > JB > > > >> Le 1 avr. 2020 à 15:44, Jean-Baptiste Onofre <j...@nanthrax.net> a écrit : > >> > >> Hmm, it seems that Jenkins is also happy with the tests: > >> > >> https://builds.apache.org/view/K/view/Karaf/job/karaf-decanter-master/1319/org.apache.karaf.decanter.collector$org.apache.karaf.decanter.collector.camel/testReport/ > >> > >> <https://builds.apache.org/view/K/view/Karaf/job/karaf-decanter-master/1319/org.apache.karaf.decanter.collector$org.apache.karaf.decanter.collector.camel/testReport/> > >> > >> Regards > >> JB > >> > >>> Le 1 avr. 2020 à 14:48, Francois Papon <francois.pa...@openobject.fr> a > >>> écrit : > >>> > >>> Hi JB, > >>> > >>> I have an error in the unit tests in the camel collector (jdk8 & 11): > >>> > >>> [main] INFO foo - Exchange[ExchangePattern: InOnly, BodyType: String, > >>> Body: TEST] > >>> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.134 sec > >>> <<< FAILURE! - in > >>> org.apache.karaf.decanter.collector.camel.DecanterTraceEventHandlerTest > >>> testTracer(org.apache.karaf.decanter.collector.camel.DecanterTraceEventHandlerTest) > >>> Time elapsed: 0.081 sec <<< ERROR! > >>> java.lang.NullPointerException: no mapping for to2_label > >>> at > >>> org.apache.johnzon.core.JsonObjectImpl.valueOrExcpetion(JsonObjectImpl.java:52) > >>> at > >>> org.apache.johnzon.core.JsonObjectImpl.getString(JsonObjectImpl.java:85) > >>> at > >>> org.apache.karaf.decanter.collector.camel.DecanterTraceEventHandlerTest.testTracer(DecanterTraceEventHandlerTest.java:58) > >>> > >>> > >>> Results : > >>> > >>> Tests in error: > >>> DecanterTraceEventHandlerTest.testTracer:58 » NullPointer no mapping for > >>> to2_l... > >>> > >>> Tests run: 7, Failures: 0, Errors: 1, Skipped: 0 > >>> > >>> regards, > >>> > >>> François > >>> fpa...@apache.org > >>> > >>> Le 01/04/2020 à 13:49, Jean-Baptiste Onofre a écrit : > >>>> Hi all, > >>>> > >>>> I submit Apache Karaf Decanter 2.3.0 release to your vote. It’s a major > >>>> release on the Decanter 2.x series, containing bug fixes, improvements > >>>> and new features, especially: > >>>> > >>>> - Complete new alerting service with powerful new features (see blog > >>>> http://blog.nanthrax.net/?p=991 <http://blog.nanthrax.net/?p=991>) > >>>> - New prometheus appender (see blog http://blog.nanthrax.net/?p=1002 > >>>> <http://blog.nanthrax.net/?p=1002>) > >>>> - Camel MessageHistory support > >>>> - Velocity templates support in email alerter > >>>> - and much more ! > >>>> > >>>> Take a look on the Release Notes for details. > >>>> > >>>> Release Notes: > >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12345165 > >>>> > >>>> <https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12345165> > >>>> > >>>> Git Tag: > >>>> Decanter-2.3.0 > >>>> > >>>> Staging Repository: > >>>> https://repository.apache.org/content/repositories/orgapachekaraf-1140/ > >>>> <https://repository.apache.org/content/repositories/orgapachekaraf-1140/> > >>>> > >>>> Staging Dist: > >>>> https://dist.apache.org/repos/dist/dev/karaf/decanter/2.3.0/ > >>>> <https://dist.apache.org/repos/dist/dev/karaf/decanter/2.3.0/> > >>>> > >>>> Please vote to approve this release: > >>>> > >>>> [ ] +1 Approve the release > >>>> [ ] -1 Don't approve the release (please provide specific comments) > >>>> > >>>> This vote will be open for at least 72 hours. > >>>> > >>>> Regards > >>>> JB
