rmannibucau commented on PR #34: URL: https://github.com/apache/karaf-minho/pull/34#issuecomment-1321854471
Hi, Wonder if this shouldn't be reverted since it open doors to a lot of issues like a leak (close hook does not reset the instance), concurrency inconsistency (you can get > 1 minho instance, which one is right?). I propose to move it to a service (GlobalInstanceService) which would be usable with something like `GlobalInstanceService.get().getMinho()`. The service wouldn't be auto-registered but explicitly registered using Minho builder API. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
