Agreed!
On Mon, Feb 26, 2024 at 11:20 AM ricardo zanini fernandes < [email protected]> wrote: > @Alex Porcelli <[email protected]> indeed we will need to > review the docs, but the preview structure will remain I believe. > > On Mon, Feb 26, 2024 at 12:48 PM Dominik Hanak <[email protected]> > wrote: > >> +1 >> >> On Mon, 26 Feb 2024 at 16:09, Alex Porcelli <[email protected]> wrote: >> >> > +1 from me (although I think we'll have to revisit the whole docs >> > shortly after 10) >> > >> > On Mon, Feb 26, 2024 at 9:57 AM ricardo zanini fernandes >> > <[email protected]> wrote: >> > > >> > > The correct action name is "maintain-one-comment". >> > > >> > > On Mon, Feb 26, 2024 at 11:55 AM ricardo zanini fernandes < >> > > [email protected]> wrote: >> > > >> > > > Hi! >> > > > >> > > > As you can see in this PR [1], we are to use surge.sh to upload docs >> > > > preview once someone sends a PR. >> > > > >> > > > This preview tool is very useful since reviewers can look at the >> actual >> > > > website the PR has updated. >> > > > >> > > > To make this work, we need to whitelist the $SUBJECT action [2] so >> the >> > > > workflow can post a comment to the PR with the preview link (which >> > will be >> > > > torn down once it's closed). >> > > > >> > > > I've raised this to accommodate ASF policies. So +1s are >> appreciated. >> > > > >> > > > We can later implement the same for Jenkins Comments instead of >> having >> > it >> > > > spamming multiple comments in a PR. >> > > > >> > > > Cheers! >> > > > >> > > > [1] https://github.com/apache/incubator-kie-kogito-docs/pull/539 >> > > > [2] https://issues.apache.org/jira/browse/INFRA-25513 >> > > > -- >> > > > Ricardo Zanini Fernandes >> > > > Vida longa e próspera. >> > > > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> > >> >
