Hello, short assessment of the CI impact for jenkins pipelines using the kogito-pipelines framework.
The relevant registry and credentials change should be mostly scoped to the branch.yaml configuration files, and DSL job generation then spreads the change across pipelines. There are of course 2 exceptions: - pr_check.groovy script we use for jenkins PR checks - the kogito-ci-build-image needs is referenced there directly - Jenkinsfile.build-kogito-ci-image pipeline to release the kogito-ci-build-image explicitly mentions quay and credentials too Both cases are due to the github-branch-source-plugin not allowing to pass env variables, so it can't inherit the configuration from the yaml config file, an old story. In our jenkins shared libraries, in cloud.groovy library that is, there are quay-specific methods like makeQuayImagePublic, etc - this is present in kogito-images, kogito-serverless-operator pipelines, grep the repositories for 'cloud.makeQuayImagePublic' to check occurrences. They should be applied only when the registry is quay.io - but would be great to assess if we need this logic also in dockerhub. There are more direct references of quay.io images elsewhere (kogito-runtimes, optaplanner, ...) but those seem to be plain string replace candidates. Regards Jan On Tue, 14 May 2024 at 21:43, Rodrigo Antunes <[email protected]> wrote: > +1 > > I can help Jan with #3 > > On 2024/05/14 16:58:25 ricardo zanini fernandes wrote: > > Tiago, > > > > I think we should stick to: > > https://hub.docker.com/u/apache/incubator-kie-sonataflow-operator/ for > > instance. That's my understanding of the guidelines. Even though we have > > many images, I think that's the way they recommend. > > > > I'll put together a spreadsheet with the new naming and attach it to a > new > > thread. > > > > > > > > On Tue, May 14, 2024 at 1:48 PM Tibor Zimányi <[email protected]> > wrote: > > > > > +1 > > > > > > Dňa ut 14. 5. 2024, 18:43 Pere Fernandez (apache) <[email protected] > > > > > napísal(a): > > > > > > > +1 > > > > > > > > El dt., 14 de maig 2024, 17:28, Enrique Gonzalez Martinez < > > > > [email protected]> va escriure: > > > > > > > > > +1 > > > > > > > > > > El mar, 14 may 2024, 17:25, Thiago Lugli <[email protected]> > > > escribió: > > > > > > > > > > > +1 > > > > > > > > > > > > For repositories with multiple images the naming should be > something > > > > like > > > > > > https://hub.docker.com/u/apache/incubator-kie- > > > > > <project_name>/<image_name< > > > > > > > > > > > > > > > > > > > https://hub.docker.com/u/apache/incubator-kie-%3cproject_name%3e/%3cimage_name > > > > > >> > > > > > > ? > > > > > > > > > > > > From: ricardo zanini fernandes <[email protected]> > > > > > > Date: Tuesday, 14 May 2024 at 12:12 > > > > > > To: [email protected] <[email protected]> > > > > > > Subject: [PROPOSAL] - Migrating from Quay to Dockerhub > > > > > > Folks, > > > > > > > > > > > > We need to move to Dockerhub from Quay for our first release duo > to > > > > > Apache > > > > > > Guidelines [1]. > > > > > > > > > > > > Here's my initial impact assessment: > > > > > > > > > > > > - *Kogito Runtimes* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-runtimes+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - A few properties, tests, CI files > > > > > > > > > > > > - *Kogito Apps* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-apps+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - One commented file > > > > > > > > > > > > - *Kogito Examples* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-apps+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - Examples instructions, tests, CI files > > > > > > - Get rid of examples using deprecated images > > > > > > > > > > > > - *Kogito Images* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-images+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - Build scripts > > > > > > - Configuration bundles > > > > > > - Documentation > > > > > > > > > > > > - *Kogito Docs* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-docs+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - Documentation :) > > > > > > > > > > > > - *Kogito Serverless Operator* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-serverless-operator+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - Default configuration, bundle, build scripts, CI, default > > > constants > > > > > > > > > > > > - *Drools* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-drools%20quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - CI config > > > > > > > > > > > > - *OptaPlanner* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-optaplanner%20quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - CI config > > > > > > > > > > > > - *Kogito Pipelines* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-kogito-pipelines+quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - Configuration, kogito-ci-build to be retagged > > > > > > > > > > > > - *OptaPlanner Quickstarts* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-optaplanner-quickstarts%20quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - No impact > > > > > > > > > > > > - *Kie Tools* ( > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=repo%3Aapache%2Fincubator-kie-tools%20quay.io%2Fkiegroup&type=code > > > > > > ) > > > > > > - SonataFlow Operator, Images package same work we will do in > the > > > > > single > > > > > > repos. > > > > > > - A few examples > > > > > > > > > > > > Once we merge all the PRs, we need to add the credentials to our > CI > > > > > > (nightly, release, etc). I'll open a JIRA [2] to request admin > > > > > credentials > > > > > > to the Apache Dockerhub repo. > > > > > > > > > > > > Outlining the plan: > > > > > > > > > > > > 1. Open PRs replacing the naming (new should be* > > > > > > https://hub.docker.com/u/apache/incubator-kie-* > > > > > > <https://hub.docker.com/u/apache/incubator-kie-*>*< > > > > > > https://hub.docker.com/u/apache/incubator-kie-*%3e*>) > > > > > > 2. Open the JIRA requesting credentials > > > > > > 3. Sertup CI to receive the new tokens and do the necessary > changes > > > to > > > > > push > > > > > > to the Dockerhub repo (tags should reflect the distribution > > > guidelines) > > > > > > > > > > > > I can take #1 and #2. Do we have a contributor to help with #3? > > > > > > > > > > > > Please +1 if you agree with this plan. We can evolve/break down > task > > > #3 > > > > > if > > > > > > needed. I'd like to hear from you if there's something else we > need > > > > > > CI-wise. > > > > > > > > > > > > Cheers! > > > > > > > > > > > > [1] https://incubator.apache.org/guides/distribution.html > > > > > > [2] https://issues.apache.org/jira/browse/INFRA-25736 > > > > > > > > > > > > -- > > > > > > Ricardo Zanini Fernandes > > > > > > Vida longa e próspera. > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
