Thank you very much for your detailed review, Toshiya! This is very helpful, and hopefully this will reduce the need of future rc’s.
On Thu, Oct 3, 2024 at 4:10 AM Toshiya Kobayashi <toshiyakobaya...@gmail.com> wrote: > [ ] Can compile from source. > > incubator-kie-drools -> success > incubator-kie-optaplanner -> success > incubator-kie-kogito-runtimes -> success > incubator-kie-kogito-apps -> success > incubator-kie-kogito-images -> success > incubator-kie-tools -> failed ( > https://gist.github.com/tkobayas/c98c86e9a1db11c94cd9d59763a1c27e) > > Probably the failure is due to my environment. Next time (rc2), I'll > investigate further. > > Sorry for polluting the mail thread, but I hope recording the result may > help in the future. > > Regards, > Toshiya > > On Thu, Oct 3, 2024 at 2:28 PM Toshiya Kobayashi < > toshiyakobaya...@gmail.com> > wrote: > > > [ ] No compiled archives bundled in source archive. > > > > > > [tkobayas incubator-kie-10.0.0-rc1-sources]$ find . | grep -E '\.jar$' > > > > > ./incubator-kie-drools/kie-ci/src/test/resources/kjar/kjar-module-before.jar > > > ./incubator-kie-drools/kie-ci/src/test/resources/kjar/kjar-module-after.jar > > > > > ./incubator-kie-drools/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar > > ./incubator-kie-drools/drools-compiler/src/test/resources/KAModelTest.jar > > ./incubator-kie-drools/drools-compiler/src/test/resources/primespoc.jar > > > > > ./incubator-kie-drools/drools-compiler/src/test/resources/eventing-example.jar > > > > > ./incubator-kie-drools/drools-compiler/src/test/resources/JarWithSourceFiles.jar > > > > > ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar > > > > > ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar > > > > > ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/kie-project-simple-1.0.0.jar > > > > > ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/org/drools/mvel/compiler/compiler/xml/changeset/changeset.jar > > > > > ./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar > > > > > ./incubator-kie-drools/drools-legacy-test-util/src/test/resources/billasurf.jar > > > > > ./incubator-kie-drools/efesto/efesto-core/efesto-runtime-manager/efesto-runtime-manager-core/src/test/resources/TestJar.jar > > > > > ./incubator-kie-drools/efesto/efesto-core/efesto-common-api/src/test/resources/TestJar.jar > > > > > ./incubator-kie-drools/efesto/efesto-core/efesto-common-core/src/test/resources/TestJar.jar > > ./incubator-kie-kogito-apps/.mvn/wrapper/maven-wrapper.jar > > ./incubator-kie-kogito-runtimes/.mvn/wrapper/maven-wrapper.jar > > > > > ./incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-core/src/test/resources/empty.jar > > > > > ./incubator-kie-kogito-runtimes/quarkus/integration-tests/integration-tests-quarkus-gradle/integration-tests-quarkus-gradle-project/gradle/wrapper/gradle-wrapper.jar > > > > > ./incubator-kie-tools/packages/stunner-editors/errai-ui/src/test/resources/less.jar > > > > Most of them are test resources, so I think they are acceptable. > > > > maven-wrapper.jar is just a tool, not a part of our release, so I think > > it's acceptable. > > > > [tkobayas incubator-kie-10.0.0-rc1-sources]$ find . | grep -E '\.zip$' > > ./incubator-kie-drools/drools-docs/ui-bundle/ui-bundle.zip > > > > > ./incubator-kie-tools/packages/serverless-logic-web-tools-swf-deployment-quarkus-app/src/test/resources/test.zip > > > > > ./incubator-kie-tools/packages/serverless-logic-web-tools-swf-deployment-quarkus-app/src/test/resources/test-with-invalid.zip > > > ./incubator-kie-tools/packages/dev-deployment-upload-service/tests/test.zip > > > > > ./incubator-kie-tools/packages/dashbuilder/dashbuilder-runtime-parent/dashbuilder-runtime-client/src/test/resources/empty.zip > > > > > ./incubator-kie-tools/packages/dashbuilder/dashbuilder-runtime-parent/dashbuilder-runtime-client/src/test/resources/not_valid.zip > > > > > ./incubator-kie-tools/packages/dashbuilder/dashbuilder-runtime-parent/dashbuilder-runtime-client/src/test/resources/valid_import.zip > > > > Most of them are test resources, so I think they are acceptable. > > > > ui-bundle.zip is a third party library, and I noticed that it's missing > in > > the NOTICE file. I filed a PR > > https://github.com/apache/incubator-kie-drools/pull/6110 > > > > Regards, > > Toshiya > > > > > > On Thu, Oct 3, 2024 at 1:46 PM Toshiya Kobayashi < > > toshiyakobaya...@gmail.com> wrote: > > > >> The gist links in the previous mail were broken. Re-pasting... > >> > >> drools-rat.txt -> > >> https://gist.github.com/tkobayas/51d5309bed736c2bd3caed9983927e78 > >> > >> optaplanner-rat.txt -> > >> https://gist.github.com/tkobayas/725f71081b9fec031f35f1d50cea4403 > >> > >> kogito-runtimes-rat.txt -> > >> https://gist.github.com/tkobayas/8f09b933be5744badb709333982ed6be > >> > >> kogito-apps-rat.txt -> > >> https://gist.github.com/tkobayas/ec04ec0593a4b6f078e84a924a47950e > >> > >> kogito-images-rat.txt -> no issue > >> > >> sandbox-quarkus-accelerator-rat.txt -> > >> https://gist.github.com/tkobayas/66e492b3a94c5330e03dda5750df8d66 > >> > >> kie-tools-rat.txt -> > >> https://gist.github.com/tkobayas/e6b580dae6030e86beec979dda4d372c > >> > >> On Thu, Oct 3, 2024 at 1:35 PM Toshiya Kobayashi < > >> toshiyakobaya...@gmail.com> wrote: > >> > >>> [?] All files have license headers if necessary. > >>> > >>> I run apache-rat for each project. > >>> > >>> for example > >>> ``` > >>> java -jar apache-rat-0.16.1.jar -d ./incubator-kie-tools/ | grep "== > >>> File:" > kie-tools-rat.txt > >>> ``` > >>> > >>> Here are the results: > >>> > >>> drools-rat.txt -> > >>> https://gist.github.com/tkobayas/51d5309bed736c2bd3caed9983927e78 > >>> optaplanner-rat.txt -> > >>> https://gist.github.com/tkobayas/725f71081b9fec031f35f1d50cea4403 > >>> kogito-runtimes-rat.txt -> > >>> https://gist.github.com/tkobayas/8f09b933be5744badb709333982ed6be > >>> kogito-apps-rat.txt -> > >>> https://gist.github.com/tkobayas/ec04ec0593a4b6f078e84a924a47950e > >>> kogito-images-rat.txt -> no issue > >>> sandbox-quarkus-accelerator-rat.txt -> > >>> https://gist.github.com/tkobayas/66e492b3a94c5330e03dda5750df8d66 > >>> kie-tools-rat.txt -> > >>> https://gist.github.com/tkobayas/e6b580dae6030e86beec979dda4d372c > >>> > >>> Here is the criteria to accept missing license headers > >>> > >>> https://www.apache.org/legal/src-headers.html#faq-exceptions > >>> ``` > >>> ## What files in an Apache release do not require a license header? > >>> A file without any degree of creativity in either its literal elements > >>> or its structure is not protected by copyright law; therefore, such a > file > >>> does not require a license header. If in doubt about the extent of the > >>> file's creativity, add the license header to the file. > >>> > >>> It may make sense for some other files to have no license header. Three > >>> examples are: > >>> > >>> - Short informational text files; for example README, INSTALL files. > The > >>> expectation is that these files make it obvious which product they > relate > >>> to. > >>> - Test data for which the addition of a source header would cause the > >>> tests to fail. > >>> - 'Snippet' files that are included in a larger file, when the larger > >>> file would have duplicate licensing headers. > >>> > >>> PMCs should use their judgement, err on having a source header and > >>> contact legal-discuss@ if unsure. > >>> ``` > >>> > >>> I think it's a little difficult to judge, but I see that drools and > >>> kogito-runtimes configures apache-rat-plugin in pom.xml and excludes > files > >>> like generated files, test data etc. > >>> > >>> drools passes `mvn apache-rat:check` and kogito-runtimes would pass if > >>> https://github.com/apache/incubator-kie-kogito-runtimes/pull/3684 is > >>> merged. > >>> > >>> I wonder how we will review other projects. > >>> > >>> Toshiya > >>> > >>> > >>> On Thu, Oct 3, 2024 at 12:36 PM Toshiya Kobayashi < > >>> toshiyakobaya...@gmail.com> wrote: > >>> > >>>> Hi, > >>>> > >>>> I see that the vote is cancelled, but I think it's worth sharing the > >>>> results and thoughts so far. > >>>> > >>>> [x] Download KIE artifacts are valid. > >>>> [x] Checksums and PGP signatures are valid. > >>>> > >>>> Note: https://kie.apache.org/docs/community/verify/ suggests `gpg > >>>> --edit-key kie`, but it may pick up "Tiago Bento (Apache KIE release > >>>> signing)", but the key didn't sign the rc1 files. In order to pick > "Apache > >>>> KIE Automated Release Signing" key, use `gpg --edit-key "Apache KIE > >>>> Automated Release Signing"`. I sent an PR > >>>> https://github.com/apache/incubator-kie-website/pull/6 > >>>> > >>>> [x] Source code distributions have correct names matching the current > >>>> release. > >>>> [ ] LICENSE and NOTICE files are correct. > >>>> > >>>> *** incubator-kie-sandbox-quarkus-accelerator doesn't have LICENSE and > >>>> NOTICE. Is it expected? *** > >>>> > >>>> Regards, > >>>> Toshiya > >>>> > >>>> On Wed, Oct 2, 2024 at 10:58 PM Alex Porcelli <porce...@apache.org> > >>>> wrote: > >>>> > >>>>> I spoke too soon. Unfortunately we'll need a RC2. > >>>>> > >>>>> I'll have to cancel the vote. > >>>>> > >>>>> On Wed, Oct 2, 2024 at 7:52 AM Alex Porcelli <porce...@apache.org> > >>>>> wrote: > >>>>> > > >>>>> > Thank you very much for your diligence, Walter! > >>>>> > > >>>>> > We already identified the issue on the upload! > >>>>> > > >>>>> > We are triggering again the pipeline and I’ll get back here to > >>>>> update as soon as the new files are uploaded. > >>>>> > > >>>>> > Alex > >>>>> > > >>>>> > > >>>>> > On Wed, Oct 2, 2024 at 3:56 AM Walter Medvedeo < > wmedve...@gmail.com> > >>>>> wrote: > >>>>> >> > >>>>> >> Hello guys, it looks like the sonataflow operator devmode and > >>>>> builder > >>>>> >> images are empty, see below: > >>>>> >> > >>>>> >> docker load < > >>>>> incubator-kie-10.0.0-rc1-sonataflow-devmode-image.tar.gz > >>>>> >> open /var/lib/docker/tmp/docker-import-3215508766/repositories: no > >>>>> such > >>>>> >> file or directory > >>>>> >> > >>>>> >> docker load < > >>>>> incubator-kie-10.0.0-rc1-sonataflow-builder-image.tar.gz > >>>>> >> open /var/lib/docker/tmp/docker-import-396410757/repositories: no > >>>>> such file > >>>>> >> or directory > >>>>> >> > >>>>> >> I think it's a -1, at least for these images. > >>>>> >> > >>>>> >> Regards, > >>>>> >> Walter. > >>>>> >> > >>>>> >> > >>>>> >> > >>>>> >> El mié, 2 oct 2024 a las 1:56, Alex Porcelli (< > porce...@apache.org > >>>>> >) > >>>>> >> escribió: > >>>>> >> > >>>>> >> > Hello, Apache KIE(incubating) Community: > >>>>> >> > > >>>>> >> > I'm thrilled to announce our first call for a vote to release > >>>>> Apache > >>>>> >> > KIE(Incubating) under the Apache Foundation! This is a > significant > >>>>> >> > milestone for our project, and we're excited to share version > >>>>> 10.0.0-rc1 > >>>>> >> > with the community. > >>>>> >> > > >>>>> >> > It's worth noting that our last community release was in > >>>>> September 2023. > >>>>> >> > Since then, our dedicated community has worked tirelessly to > >>>>> adjust to our > >>>>> >> > new home within the Apache Foundation. The effort and commitment > >>>>> shown > >>>>> >> > during this transition period have been truly remarkable, and we > >>>>> couldn't > >>>>> >> > be more excited about this release. > >>>>> >> > > >>>>> >> > The release candidate: > >>>>> >> > > https://dist.apache.org/repos/dist/dev/incubator/kie/10.0.0-rc1/ > >>>>> >> > > >>>>> >> > The maven staging for this release: > >>>>> >> > Drools: > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1042 > >>>>> >> > Optaplanner: > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1009 > >>>>> >> > Kogito Runtimes: > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1012 > >>>>> >> > Kogito Apps: > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1014 > >>>>> >> > Kogito Apps (JIT Executor Native linux): > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1018 > >>>>> >> > Kogito Apps (JIT Executor Native windows): > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1019 > >>>>> >> > Kogito Apps (JIT Executor Native mac): > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1020 > >>>>> >> > KIE Tools (JBPM Quarkus DevUI): > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1021 > >>>>> >> > KIE Tools (Sonataflow Quarkus DevUI): > >>>>> >> > > >>>>> https://repository.apache.org/content/repositories/orgapachekie-1039 > >>>>> >> > > >>>>> >> > The artifacts are signed with PGP key corresponding to [ > >>>>> >> > priv...@kie.apache.org], that can be found in keys file: > >>>>> >> > https://downloads.apache.org/incubator/kie/KEYS > >>>>> >> > > >>>>> >> > The vote will be open for at least 72 hours until the necessary > >>>>> number of > >>>>> >> > votes are reached. > >>>>> >> > > >>>>> >> > Please vote accordingly: > >>>>> >> > > >>>>> >> > [ ] +1 approve > >>>>> >> > [ ] +0 no opinion > >>>>> >> > [ ] -1 disapprove with the reason > >>>>> >> > > >>>>> >> > To learn more about KIE, please see https://kie.apache.org/ > >>>>> >> > > >>>>> >> > *Valid check is a requirement for a vote.* Checklist for > >>>>> reference: > >>>>> >> > > >>>>> >> > [ ] Download KIE artifacts are valid. > >>>>> >> > [ ] Checksums and PGP signatures are valid. > >>>>> >> > [ ] Source code distributions have correct names matching the > >>>>> current > >>>>> >> > release. > >>>>> >> > [ ] LICENSE and NOTICE files are correct. > >>>>> >> > [ ] All files have license headers if necessary. > >>>>> >> > [ ] No compiled archives bundled in source archive. > >>>>> >> > [ ] Can compile from source. > >>>>> >> > > >>>>> >> > More detail checklist please refer: > >>>>> >> > > >>>>> >> > > >>>>> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > >>>>> >> > > >>>>> >> > For more information on how to verify the release, please refer > >>>>> to: > >>>>> >> > https://kie.apache.org/docs/community/verify > >>>>> >> > > >>>>> >> > For more information on how to how to build, please refer to: > >>>>> >> > https://kie.apache.org/docs/community/build > >>>>> >> > > >>>>> >> > Thanks, > >>>>> >> > Alex > >>>>> >> > > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org > >>>>> For additional commands, e-mail: dev-h...@kie.apache.org > >>>>> > >>>>> >
