> https://github.com/apache/incubator-kie-optaplanner/pull/3130 (Merged)
for optaplanner, it's good to look at this PR now: https://github.com/apache/incubator-kie-optaplanner/pull/3144 On Tue, Nov 26, 2024 at 3:55 PM Toshiya Kobayashi < [email protected]> wrote: > Hi, > > I think every committer needs to be aware of the requirements, because > this topic always matters while we maintain source codes. > > Per discussion > https://lists.apache.org/thread/nrq50szwx37doopb23wyq33v0t3bbccg , > > https://issues.apache.org/jira/browse/LEGAL-469 > `3rd party Category X or Category B bundled code licenses not listed in > LICENSE` is the one major blocker of the 10.0.0 release. > > It means, if we have Category X or Category B licensed source code, we > have to list the file path and its license in the `LICENSE` file at this > stage. (Eventually, we will need to remove them before incubator graduation) > > "Category" is explained here: https://www.apache.org/legal/resolved.html > > In the discussion, 2 cases were highlighted. > > - > `./incubator-kie-tools/packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/compat/javax/annotation/processing/Generated.java`, > which is dual licensed --- CDDL (Category B) or GPL (Category X). > -> For main, it's handled by > https://github.com/apache/incubator-kie-tools/pull/2746 , but make sure > that it's resolved in 10.0.0 build. > > - `incubator-kie-drools/drools-docs/supplemental-ui/js/search-ui.js`, > which is MPL (Category B). > -> We will exclude `drools-docs` from the source distribution. > > However, there may be more cases. We need to scrutinize all source codes > to find source codes with licenses missing in the `LICENSE` file. > > I filed a GH issue for this with the steps to check. > > https://github.com/apache/incubator-kie-issues/issues/1634 > > I have done the check for drools. For other repos, the following PRs > are/were fixing license issues. > > https://github.com/apache/incubator-kie-optaplanner/pull/3130 (Merged) > https://github.com/apache/incubator-kie-kogito-runtimes/pull/3714 > https://github.com/apache/incubator-kie-kogito-apps/pull/2111 > https://github.com/apache/incubator-kie-tools/pull/2746 > > I think all these PRs made good progress (might fix all issues), but it > would be great if more people review from this point of view. > > Alex might start rc4 build, so new findings may not be in time for rc4, > but it should be good to proceed the work. > > Cheers, > Toshiya >
