Reverted. If I recall correctly, the reason I did the change (incompletely, because I forgot to include the runtime module, but this was not possible to detect when running locally using snapshots, it will be certainly apparent when releasing) was because I see that the artifacts in full profile (but not in regular one) are apparently not released and there are users that would like to have the python functionality, but it was only available as snapshot. So, my question is, can we also release artifacts that are only in full profile?
On Tue, Apr 1, 2025 at 12:10 PM Francisco Javier Tirado Sarti < ftira...@redhat.com> wrote: > Ill fix right away now > > On Tue, Apr 1, 2025 at 10:16 AM Jan Šťastný <jstastn...@apache.org> wrote: > >> Obviously my thoughts collided in "I think kogito-runtimes build is not >> broken after:" - I meant the kogito-runtimes build IS broken :-) >> >> On Tue, 1 Apr 2025 at 10:03, Jan Šťastný <jstastn...@apache.org> wrote: >> >> > Hello all, >> > >> > I think kogito-runtimes build is not broken after: >> > https://github.com/apache/incubator-kie-kogito-runtimes/pull/3863 >> > >> > The change in the linked PR moved the module quarkus/addons/python into >> > the default reactor, instead of the original 'full' profile. >> > Problem is that this module has dependencies on other python-related >> > modules inside kogito-runtimes which are NOT in the default reactor, but >> > still in 'full' profile. >> > >> > As a result the build is broken for users not running the 'full' profile >> > explicitly - in which case a stale snapshot of the dependencies which >> are >> > by default not part of the reactor is used. >> > >> > I've commented on the original PR too. >> > >> > Similar changes need to be well tested in affected build "modes", if >> we're >> > moving things from profile into default build, we need to test both >> builds >> > - and keep in mind, CI does NOT necessarily run builds in all the >> possible >> > setups (I think it runs full profile, so the problem was not apparent). >> > >> > @Francisco if you could either revert your change or fix the setup in a >> > reasonably short time. >> > >> > Regards >> > Jan >> > >> >
