I totally agree freezing PF4 work is not really an option. But it also quite difficult to forecast the closing time for this PR as many "variables" are involved and there can be blockers not related to our changes.
For instance the ubuntu-1 GHA is currently failing because GH web UI changed something and the Serverless Workflow Chrome Extension is not passing the tests in this PR but also in this one, which is not related to our work: https://github.com/apache/incubator-kie-tools/pull/3041 I'm working on this fix. In addition to this, I think establishing a good way to handle this core activities will help us on the next ones as we still have to update React, Patternfly v6. On Wed, 2025-04-02 at 13:42 +0000, Jozef Marko wrote: > Hi Fabrizio, as this is very crucial PR, I can imagine also we > 'block' PRs that contain patternfly changes until the big PF4 -> PF5 > PR is merged. I can imagine this only if we are confident enough PF4 > -> PF5 PR will be merged in a week? or two weeks? Not sure what > should be such 'blocking window' size. > > Personally, I can not imagine we do similar 'blocking window' longer > than two weeks. Ideal 'blocking window' size doesn't exist for sure. > We would probably agree - the shorter the better. > > > Jozef Marko > > Software Developer > > jozef.ma...@ibm.com > > > > ________________________________ > From: Fabrizio Antonangeli <fantonang...@apache.org> > Sent: Tuesday, April 1, 2025 4:00 PM > To: dev@kie.apache.org <dev@kie.apache.org> > Subject: [EXTERNAL] [PROPOSAL] Coordinating PatternFly 5 Upgrade > Effort > > Hello all, > > Aditya and I are very close to finishing a PR for updating PatternFly > to v5 [1]. The main problem we have is that while we update, fix > issues, and run the CI, the work on the main branch using PF4 > continues. This means we have to continuously sync our PR, update the > new code to PF5, re-test, and check the CI. > > The CI also takes time to run, as all frontend packages use > PatternFly, > and the CI tests all of them. Once everything is green, reviewers may > also need time to go through the PR (which includes 530 files), while > in the meantime, PF4 development on `main` continues. > > Since I don't think we can freeze PF4 work until the PF5 update is > completed, my suggestion is to establish a temporary "rule": > > Anyone developing PF4 code on main should also open a PR on > Aditya's `allpackagesp4top5` branch with the corresponding PF5 > update. > > This would be required only until the PR is reviewed and merged. > > Alternatively, can we "split" our work into SWF-related updates and > Online Editor-related work? > > As always, I'm open to other ideas. > > [1] https://github.com/apache/incubator-kie-tools/pull/2853 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org > For additional commands, e-mail: dev-h...@kie.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org For additional commands, e-mail: dev-h...@kie.apache.org