+1 I agree with this proposal to make code buildable and runnable with Java 21
Regards, Deepak Joseph On Thu, Jul 31, 2025 at 1:35 PM Yeser Amer <ya...@apache.org> wrote: > Thank you for the clarification, +1 (and I'm available to help in this > effort) > > On 2025/07/31 07:52:36 Tibor Zimányi wrote: > > Hi, > > > > thanks for the feedback. It is basically as Francisco wrote. We have > Maven > > properties configured with 17, but there was no coordinated effort yet to > > find out if everything works also on 21. This proposal is about it. There > > may be multiple things not working with 21, as e.g. mentioned in GWT, or > > there may be some enforcer rules around jdks etc. This effort should make > > sure everything is buildable and runnable on both Java 21 and Java 17. > > > > For the PR checks, I think we can have a broader discussion if we agree > on > > this one and when we get to the point of starting the Phase 2. I am not > > against having a Java 17 PR check, it may be useful. It just needs to be > > scoped properly (e.g. I expect not all PR checks are needed as Java 17 > ones > > etc.). > > > > Hope that clarifies. > > > > Best regards, > > Tibor > > > > On Thu, Jul 31, 2025 at 9:36 AM Yeser Amer <ya...@apache.org> wrote: > > > > > Dmitrii, > > > > > > At that moment, I experimented with GWT 2.10. Indeed it could be worth > > > trying again with 2.12, thank you for pointing that. > > > > > > On 2025/07/30 17:40:46 Dmitrii Tikhomirov wrote: > > > > This is strange, because at present GWT’s minimum Java version is 11, > > > and the supported source level is 17. As far as I understand, it should > > > work with version 21 as well > > > > > > > > https://github.com/gwtproject/gwt/releases/tag/2.12.0 > > > > > > > > > > > > > > > > > On Jul 30, 2025, at 7:59 AM, Yeser Amer <ya...@apache.org> wrote: > > > > > > > > > > Right, it makes sense. > > > > > > > > > > A point to share is that we have all GWT modules with that property > > > set to JDK 8, because I failed to compile our GWT sources with any JDK > 8+, > > > when I tried some months ago. > > > > > > > > > > On 2025/07/30 14:49:05 Francisco Javier Tirado Sarti wrote: > > > > >> I was going to say that, as far as I know, all modules should be > set > > > to 17 > > > > >> now. Anyway, the task is to verify that assumption is true. > > > > >> > > > > >> On Wed, Jul 30, 2025 at 4:43 PM Yeser Amer <ya...@apache.org> > wrote: > > > > >> > > > > >>> Tibor, > > > > >>> > > > > >>> Thank you for your initiative, can you please clarify: > > > > >>> > > > > >>>> Phase 1: > > > > >>>> - Setting the release property: > > > > >>>> <maven.compiler.release>17</maven.compiler.release>. > > > > >>> > > > > >>> That means that we currently have some modules with JDK version > < 17, > > > > >>> right? > > > > >>> > > > > >>>> Phase 2: > > > > >>>> - Update the KIE CI to use Java 21 by default. This means: > > > > >>>> - Making sure PR checks run with Java 21. > > > > >>>> - Making sure the release builds run with Java 21. > > > > >>> > > > > >>> If I understood correctly, we have to support both JDK 17 and > JDK 21 > > > for a > > > > >>> while. Should we expect to have 2 subsets of PR Checks, one that > runs > > > > >>> against JDK 17 and one that compiles against JDK 21 (optaplanner > is > > > > >>> correctly doing that against JDK 17 and 20)? > > > > >>> > > > > >>> Thanks > > > > >>> > > > > >>> Yeser > > > > >>> > > > > >>> > > > > >>> On 2025/07/30 11:54:23 Tibor Zimányi wrote: > > > > >>>> Hi everyone, > > > > >>>> > > > > >>>> as Java 21 is the latest Java LTS available, already for some > time, > > > I > > > > >>> would > > > > >>>> like to propose that the code should be buildable and runnable > with > > > Java > > > > >>>> 21, while still retaining compatibility with Java 17. > > > > >>>> > > > > >>>> The work should be split into two phases like this: > > > > >>>> Phase 1: > > > > >>>> - Setting the release property: > > > > >>>> <maven.compiler.release>17</maven.compiler.release>. > > > > >>>> - This should make sure the code works with Java 17. > > > > >>>> - This should make sure that the existing CI still works the > > > same way > > > > >>>> and is able to build releases etc., because even if we have > Java 17 > > > as a > > > > >>>> build environment, with the setting, it should work. > > > > >>>> - Fixing the problems that occur while trying to build the > > > repositories > > > > >>>> with Java 21 and are caused by Java 21. > > > > >>>> - Fixing the problems that occur while running tests with Java > 21 > > > and are > > > > >>>> caused by Java 21. > > > > >>>> - Updating the images we publish and need JDK to contain JDK 21 > > > instead > > > > >>> of > > > > >>>> 17. > > > > >>>> - Target of the work are all Apache KIE repositories, mainly: > > > > >>>> incubator-kie-drools, incubator-kie-optaplanner, > > > > >>>> incubator-kie-kogito-runtimes, incubator-kie-kogito-apps, > > > > >>>> incubator-kie-kogito-examples, incubator-kie-tools. > > > > >>>> > > > > >>>> Phase 2: > > > > >>>> - Update the KIE CI to use Java 21 by default. This means: > > > > >>>> - Making sure PR checks run with Java 21. > > > > >>>> - Making sure the release builds run with Java 21. > > > > >>>> > > > > >>>> What do you think, please? I plan to open a vote on Monday > based on > > > the > > > > >>>> feedback of this discussion. Finding people to do this work is > > > already > > > > >>>> done, at least for Phase 1. > > > > >>>> > > > > >>>> Best regards, > > > > >>>> Tibor > > > > >>>> > > > > >>> > > > > >>> > --------------------------------------------------------------------- > > > > >>> To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org > > > > >>> For additional commands, e-mail: dev-h...@kie.apache.org > > > > >>> > > > > >>> > > > > >> > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org > > > > > For additional commands, e-mail: dev-h...@kie.apache.org > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org > > > For additional commands, e-mail: dev-h...@kie.apache.org > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@kie.apache.org > For additional commands, e-mail: dev-h...@kie.apache.org > >
