[ 
https://issues.apache.org/jira/browse/KNOX-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966784#comment-13966784
 ] 

Larry McCay commented on KNOX-344:
----------------------------------

I'm not much of a fan of hardcoding passwords in code that is not tests and 
especially of using the variable "master" for it. Samples shouldn't encourage 
bad practices but putting passwords in clear text in a properties file isn't 
much better. We can choose to address it later.

+1

Go ahead and commit.

> Update documentation/samples to be consistent with Hive 0.13.
> -------------------------------------------------------------
>
>                 Key: KNOX-344
>                 URL: https://issues.apache.org/jira/browse/KNOX-344
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Site
>    Affects Versions: 0.4.0
>            Reporter: Maksim Kononenko
>            Assignee: Maksim Kononenko
>             Fix For: 0.4.0
>
>         Attachments: KNOX-344_doc_v_2.patch, KNOX-344_samples_v_2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to