[
https://issues.apache.org/jira/browse/KNOX-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165373#comment-14165373
]
Larry McCay edited comment on KNOX-422 at 10/9/14 5:04 PM:
-----------------------------------------------------------
Hi [~poliva] -
Again, sorry for the delay in getting this reviewed.
I would very much like to get this committed for the 0.5.0 release.
2 minor things to address in the patch and I think we are ready to go:
1. BaseKeystoreService is not a X509CertificateUtil in the OO sense. Let's not
have BaseKeystoreService extend that class. Also make the util class have
public static method for certificate generation. That is generally the pattern
used for Util classes.
2. The error message should be changed to be more like the following and pass
in the exception. This error should halt system start up and we need to
communicate why it failed to be generated. Also note the change in the error
message itself. You can make it "Error" if you want but it would have to be
something like "Error in generating certificate {0}" instead.
{code}
@Message( level = MessageLevel.ERROR, text = "Failed to generate certificate:
{0}" )
void failedToGenerateCertificate( @StackTrace( level = MessageLevel.ERROR )
Exception e );
{code}
We should be able to get this into 0.5.0 with these minor changes.
Thanks again for your contributions.
was (Author: lmccay):
Hi [~poliva] -
Again, sorry for the delay in getting this reviewed.
I would very much like to get this committed for the 0.5.0 release.
2 minor things to address in the patch and I think we are ready to go:
1. BaseKeystoreService is not a X509CertificateUtil in the OO sense. Let's not
have BaseKeystoreService extend that class. Also make the util class have
public static method for certificate generation. That is generally the pattern
used for Util classes.
2. The error message should be changed to be more like the following and pass
in the exception. This error should halt system start up and we need to
communicate why it failed to be generated. Also note the change in the error
message itself. You can make it "Error" if you want but it would have to be
something like "Error in generating certificate {0}" instead.
{code}
@Message( level = MessageLevel.ERROR, text = "Failed to generate certificate:
{0}" )
void failedToGenerateCertificate( @StackTrace( level = MessageLevel.ERROR )
Exception e );
{code}
We should be able to get this into 0.5.0 with these minor changes.
Thanks again for your contributions.
> Build break with JVM IBM JAVA
> -----------------------------
>
> Key: KNOX-422
> URL: https://issues.apache.org/jira/browse/KNOX-422
> Project: Apache Knox
> Issue Type: Bug
> Components: Build
> Affects Versions: 0.4.0
> Environment: RHEL 7 - power pc 64 - maven 3.2.1 - Java home:
> /home/jdk/ibm/ibm-java-ppc64-71/jre
> Reporter: pascal oliva
> Fix For: 0.5.0
>
> Attachments: KNOX-422-1.patch, KNOX-422-2.patch, KNOX-422-3.patch
>
>
> The build failed with JVM IBM JAVA : Java version: 1.7.0, vendor: IBM
> Corporation
> [INFO] 30 errors
> [INFO] -------------------------------------------------------------
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] gateway ........................................... SUCCESS [ 0.510 s]
> [INFO] gateway-test-utils ................................ SUCCESS [ 1.631 s]
> [INFO] gateway-i18n ...................................... SUCCESS [ 0.290 s]
> [INFO] gateway-util-common ............................... SUCCESS [ 0.566 s]
> [INFO] gateway-util-launcher ............................. SUCCESS [ 0.190 s]
> [INFO] gateway-util-urltemplate .......................... SUCCESS [ 0.345 s]
> [INFO] gateway-test-ldap ................................. SUCCESS [ 0.349 s]
> [INFO] gateway-test-ldap-launcher ........................ SUCCESS [ 0.030 s]
> [INFO] gateway-i18n-logging-log4j ........................ SUCCESS [ 0.064 s]
> [INFO] gateway-i18n-logging-sl4j ......................... SUCCESS [ 0.060 s]
> [INFO] gateway-spi ....................................... FAILURE [ 0.701 s]
> ...
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /home/pascal/release/ibmsoe/knox/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java:[88,9]
> cannot find symbol
> symbol: class X509CertInfo
> ...
> On
> /home/pascal/release/ibmsoe/knox/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java
> import sun.security.x509.*; is not available with the JVM IBM JAVA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
