[
https://issues.apache.org/jira/browse/KNOX-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171259#comment-14171259
]
Larry McCay commented on KNOX-438:
----------------------------------
Hi [~kristopherkane] -
Thanks for the patch!
A couple things to make it better and able to be committed:
1. Tests. I think that we need to extend the WebHCatDeploymentContributorTest
to test that a url pattern of "webhcat" will be matched appropriately. I was
looking at what was needed there and think that we can mock out the descriptors
and interrogate them after calling contributeResource.
2. nit: please extract the common blocks of code out of the
WebHCatDeploymentContributor.contributeResources() into callable method/s that
take a pattern argument and just call it 4 times.
This will be a good contribution for Knox - thanks again!
> Support both templeton and webhdfs URLs
> ---------------------------------------
>
> Key: KNOX-438
> URL: https://issues.apache.org/jira/browse/KNOX-438
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.5.0
> Reporter: Larry McCay
> Fix For: 0.5.0
>
> Attachments: KNOX-438.patch
>
>
> WebHCatDeploymentContributor should add a pattern to the patterns and rules
> for webhcat. This is a convenience to better align the role in the topology
> file with the API - even though templeton is still officially used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
