[ 
https://issues.apache.org/jira/browse/KNOX-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287572#comment-14287572
 ] 

Kevin Minder commented on KNOX-489:
-----------------------------------

I hate to nit pick anyone willing to contribute tests but after running the 
tests we are left with an "Untracked file" from a git perspective: 
gateway-spi/ambari.  I can't quite see what the difference is between your 
version of the test and [~lmccay]'s that causes this.  This will cause problems 
with git workflow so it needs to be fixed.  
{code}
On branch master
Your branch is up-to-date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   
gateway-spi/src/test/java/org/apache/hadoop/gateway/services/security/impl/CMFKeystoreServiceTest.java

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        gateway-spi/ambari

no changes added to commit (use "git add" and/or "git commit -a")
{code}

> Add Unit Testcases for CMFKeystoreService
> -----------------------------------------
>
>                 Key: KNOX-489
>                 URL: https://issues.apache.org/jira/browse/KNOX-489
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Priority: Minor
>         Attachments: KNOX-489.1.patch
>
>
> 1. Improve existing Testcase , without affecting the scenario in 
> CMFKeystoreServiceTest.java
> 2. Add Unit testcase for CMFKeystoreService



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to