[ 
https://issues.apache.org/jira/browse/KNOX-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305430#comment-14305430
 ] 

Larry McCay commented on KNOX-494:
----------------------------------

Hi [~andreina] - after a quick review, I am a bit concerned that this patch may 
break existing deployments where this is encountered and is somehow working 
even though we don't find a JAVA.

Can you describe the current behavior of the gateway runtime and the knoxcli 
when JAVA is not set - can we be sure that they are not running?
If it is just bad error messages then maybe we need to merely add some warning 
and let it go?

As I said, I am concerned about breaking existing deployments that happen to be 
working.

> knox-env.sh script should exit with proper error message , if JAVA is not 
> set. 
> -------------------------------------------------------------------------------
>
>                 Key: KNOX-494
>                 URL: https://issues.apache.org/jira/browse/KNOX-494
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>         Attachments: KNOX-494.1.patch
>
>
> knox-env.sh script  does not exit when JAVA is not set .
> Hence execution of other script (which invokes knox-env.sh to set JAVA) in an 
> environment which does not contains JAVA , continues with execution and logs 
> non-user friendly messages as below
> {noformat}
> Execution of gateway.sh:
> nohup: invalid option -- 'j'
> Try `nohup --help' for more information.
> {noformat}
> {noformat}
> Execution of knoxcli.sh :
> ./knoxcli.sh: line 61: -jar: command not found
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to